Fix S2094 FP: type specifications, attributes and conditional compila…

…tion (#6784) Co-authored-by: Andrei Epure <andrei.epure@sonarsource.com>
SonarSource · Feb 24, 2023 · a06e58f · a06e58f
1 parent af2652f
commit a06e58f
Show file tree

Hide file tree

Showing 31 changed files with 227 additions and 114 deletions.
diff --git a/...ers/its/expected/Ember-MM/Ember.Plugins-{9496C697-5AFD-4813-AEDC-AF33FACEADF0}-S2094.json b/...ers/its/expected/Ember-MM/Ember.Plugins-{9496C697-5AFD-4813-AEDC-AF33FACEADF0}-S2094.json
@@ -2,7 +2,7 @@
 "issues":  [
 {
 "id":  "S2094",
-"message":  "Remove this empty class, or add members to it.",
+"message":  "Remove this empty class, write its code or make it an "interface".",
 "location":  {
 "uri":  "sources\Ember-MM\Ember.Plugins\PluginActionContext.cs",
 "region":  {

diff --git a/analyzers/its/expected/Net5/Net5--net5.0-S2094.json b/analyzers/its/expected/Net5/Net5--net5.0-S2094.json
@@ -2,7 +2,7 @@
 "issues":  [
 {
 "id":  "S2094",
-"message":  "Remove this empty class, or add members to it.",
+"message":  "Remove this empty class, write its code or make it an "interface".",
 "location":  {
 "uri":  "sources\Net5\Net5\ModuleInitializers.cs",
 "region":  {
@@ -15,7 +15,7 @@
 },
 {
 "id":  "S2094",
-"message":  "Remove this empty class, or add members to it.",
+"message":  "Remove this empty class, write its code or make it an "interface".",
 "location":  {
 "uri":  "sources\Net5\Net5\ParameterValidation.cs",
 "region":  {
@@ -28,7 +28,7 @@
 },
 {
 "id":  "S2094",
-"message":  "Remove this empty class, or add members to it.",
+"message":  "Remove this empty class, write its code or make it an "interface".",
 "location":  {
 "uri":  "sources\Net5\Net5\S2330.cs",
 "region":  {
@@ -41,7 +41,7 @@
 },
 {
 "id":  "S2094",
-"message":  "Remove this empty class, or add members to it.",
+"message":  "Remove this empty class, write its code or make it an "interface".",
 "location":  {
 "uri":  "sources\Net5\Net5\S3240.cs",
 "region":  {
@@ -54,7 +54,7 @@
 },
 {
 "id":  "S2094",
-"message":  "Remove this empty class, or add members to it.",
+"message":  "Remove this empty class, write its code or make it an "interface".",
 "location":  {
 "uri":  "sources\Net5\Net5\S3247.cs",
 "region":  {
@@ -67,7 +67,7 @@
 },
 {
 "id":  "S2094",
-"message":  "Remove this empty class, or add members to it.",
+"message":  "Remove this empty class, write its code or make it an "interface".",
 "location":  {
 "uri":  "sources\Net5\Net5\S3453.cs",
 "region":  {
@@ -80,7 +80,7 @@
 },
 {
 "id":  "S2094",
-"message":  "Remove this empty class, or add members to it.",
+"message":  "Remove this empty class, write its code or make it an "interface".",
 "location":  {
 "uri":  "sources\Net5\Net5\StaticLambdas.cs",
 "region":  {

diff --git a/analyzers/its/expected/Net7/Net7--net7.0-S2094.json b/analyzers/its/expected/Net7/Net7--net7.0-S2094.json
@@ -2,7 +2,7 @@
 "issues":  [
 {
 "id":  "S2094",
-"message":  "Remove this empty class, or add members to it.",
+"message":  "Remove this empty class, write its code or make it an "interface".",
 "location":  {
 "uri":  "sources\Net7\Net7\features\WarningWave7.cs",
 "region":  {

diff --git a/analyzers/its/expected/akka.net/Akka--netstandard2.0-S2094.json b/analyzers/its/expected/akka.net/Akka--netstandard2.0-S2094.json
@@ -2,7 +2,7 @@
 "issues":  [
 {
 "id":  "S2094",
-"message":  "Remove this empty class, or add members to it.",
+"message":  "Remove this empty class, write its code or make it an "interface".",
 "location":  {
 "uri":  "sources\akka.net\src\core\Akka\Actor\ActorSelection.cs",
 "region":  {
@@ -15,7 +15,7 @@
 },
 {
 "id":  "S2094",
-"message":  "Remove this empty class, or add members to it.",
+"message":  "Remove this empty class, write its code or make it an "interface".",
 "location":  {
 "uri":  "sources\akka.net\src\core\Akka\Actor\FSM.cs",
 "region":  {
@@ -28,7 +28,7 @@
 },
 {
 "id":  "S2094",
-"message":  "Remove this empty class, or add members to it.",
+"message":  "Remove this empty class, write its code or make it an "interface".",
 "location":  {
 "uri":  "sources\akka.net\src\core\Akka\Event\LoggerInitialized.cs",
 "region":  {
@@ -41,7 +41,7 @@
 },
 {
 "id":  "S2094",
-"message":  "Remove this empty class, or add members to it.",
+"message":  "Remove this empty class, write its code or make it an "interface".",
 "location":  {
 "uri":  "sources\akka.net\src\core\Akka\Event\Logging.cs",
 "region":  {
@@ -54,7 +54,7 @@
 },
 {
 "id":  "S2094",
-"message":  "Remove this empty class, or add members to it.",
+"message":  "Remove this empty class, write its code or make it an "interface".",
 "location":  {
 "uri":  "sources\akka.net\src\core\Akka\IO\Dns.cs",
 "region":  {
@@ -67,7 +67,7 @@
 },
 {
 "id":  "S2094",
-"message":  "Remove this empty class, or add members to it.",
+"message":  "Remove this empty class, write its code or make it an "interface".",
 "location":  {
 "uri":  "sources\akka.net\src\core\Akka\IO\Inet.cs",
 "region":  {
@@ -80,7 +80,7 @@
 },
 {
 "id":  "S2094",
-"message":  "Remove this empty class, or add members to it.",
+"message":  "Remove this empty class, write its code or make it an "interface".",
 "location":  {
 "uri":  "sources\akka.net\src\core\Akka\IO\Tcp.cs",
 "region":  {
@@ -93,7 +93,7 @@
 },
 {
 "id":  "S2094",
-"message":  "Remove this empty class, or add members to it.",
+"message":  "Remove this empty class, write its code or make it an "interface".",
 "location":  {
 "uri":  "sources\akka.net\src\core\Akka\IO\Tcp.cs",
 "region":  {
@@ -106,7 +106,7 @@
 },
 {
 "id":  "S2094",
-"message":  "Remove this empty class, or add members to it.",
+"message":  "Remove this empty class, write its code or make it an "interface".",
 "location":  {
 "uri":  "sources\akka.net\src\core\Akka\IO\Tcp.cs",
 "region":  {
@@ -119,7 +119,7 @@
 },
 {
 "id":  "S2094",
-"message":  "Remove this empty class, or add members to it.",
+"message":  "Remove this empty class, write its code or make it an "interface".",
 "location":  {
 "uri":  "sources\akka.net\src\core\Akka\IO\Udp.cs",
 "region":  {
@@ -132,7 +132,7 @@
 },
 {
 "id":  "S2094",
-"message":  "Remove this empty class, or add members to it.",
+"message":  "Remove this empty class, write its code or make it an "interface".",
 "location":  {
 "uri":  "sources\akka.net\src\core\Akka\IO\Udp.cs",
 "region":  {
@@ -145,7 +145,7 @@
 },
 {
 "id":  "S2094",
-"message":  "Remove this empty class, or add members to it.",
+"message":  "Remove this empty class, write its code or make it an "interface".",
 "location":  {
 "uri":  "sources\akka.net\src\core\Akka\IO\UdpConnected.cs",
 "region":  {
@@ -158,7 +158,7 @@
 },
 {
 "id":  "S2094",
-"message":  "Remove this empty class, or add members to it.",
+"message":  "Remove this empty class, write its code or make it an "interface".",
 "location":  {
 "uri":  "sources\akka.net\src\core\Akka\Pattern\BackoffOptions.cs",
 "region":  {
@@ -171,7 +171,7 @@
 },
 {
 "id":  "S2094",
-"message":  "Remove this empty class, or add members to it.",
+"message":  "Remove this empty class, write its code or make it an "interface".",
 "location":  {
 "uri":  "sources\akka.net\src\core\Akka\Routing\Listeners.cs",
 "region":  {
@@ -184,7 +184,7 @@
 },
 {
 "id":  "S2094",
-"message":  "Remove this empty class, or add members to it.",
+"message":  "Remove this empty class, write its code or make it an "interface".",
 "location":  {
 "uri":  "sources\akka.net\src\core\Akka\Routing\RouterMsg.cs",
 "region":  {

diff --git a/analyzers/its/expected/akka.net/Akka.Benchmarks--netcoreapp3.1-S2094.json b/analyzers/its/expected/akka.net/Akka.Benchmarks--netcoreapp3.1-S2094.json
@@ -2,7 +2,7 @@
 "issues":  [
 {
 "id":  "S2094",
-"message":  "Remove this empty class, or add members to it.",
+"message":  "Remove this empty class, write its code or make it an "interface".",
 "location":  {
 "uri":  "sources\akka.net\src\benchmark\Akka.Benchmarks\IO\TcpOperationsBenchmarks.cs",
 "region":  {
@@ -15,7 +15,7 @@
 },
 {
 "id":  "S2094",
-"message":  "Remove this empty class, or add members to it.",
+"message":  "Remove this empty class, write its code or make it an "interface".",
 "location":  {
 "uri":  "sources\akka.net\src\benchmark\Akka.Benchmarks\IO\TcpOperationsBenchmarks.cs",
 "region":  {

diff --git a/analyzers/its/expected/akka.net/Akka.Cluster--netstandard2.0-S2094.json b/analyzers/its/expected/akka.net/Akka.Cluster--netstandard2.0-S2094.json
@@ -2,7 +2,7 @@
 "issues":  [
 {
 "id":  "S2094",
-"message":  "Remove this empty class, or add members to it.",
+"message":  "Remove this empty class, write its code or make it an "interface".",
 "location":  {
 "uri":  "sources\akka.net\src\core\Akka.Cluster\ClusterDaemon.cs",
 "region":  {
@@ -15,7 +15,7 @@
 },
 {
 "id":  "S2094",
-"message":  "Remove this empty class, or add members to it.",
+"message":  "Remove this empty class, write its code or make it an "interface".",
 "location":  {
 "uri":  "sources\akka.net\src\core\Akka.Cluster\ClusterHeartbeat.cs",
 "region":  {

diff --git a/analyzers/its/expected/akka.net/Akka.DI.TestKit--netstandard2.0-S2094.json b/analyzers/its/expected/akka.net/Akka.DI.TestKit--netstandard2.0-S2094.json
@@ -2,7 +2,7 @@
 "issues":  [
 {
 "id":  "S2094",
-"message":  "Remove this empty class, or add members to it.",
+"message":  "Remove this empty class, write its code or make it an "interface".",
 "location":  {
 "uri":  "sources\akka.net\src\contrib\dependencyinjection\Akka.DI.TestKit\DiResolverSpec.cs",
 "region":  {
@@ -15,7 +15,7 @@
 },
 {
 "id":  "S2094",
-"message":  "Remove this empty class, or add members to it.",
+"message":  "Remove this empty class, write its code or make it an "interface".",
 "location":  {
 "uri":  "sources\akka.net\src\contrib\dependencyinjection\Akka.DI.TestKit\DiResolverSpec.cs",
 "region":  {
@@ -28,7 +28,7 @@
 },
 {
 "id":  "S2094",
-"message":  "Remove this empty class, or add members to it.",
+"message":  "Remove this empty class, write its code or make it an "interface".",
 "location":  {
 "uri":  "sources\akka.net\src\contrib\dependencyinjection\Akka.DI.TestKit\DiResolverSpec.cs",
 "region":  {
@@ -41,7 +41,7 @@
 },
 {
 "id":  "S2094",
-"message":  "Remove this empty class, or add members to it.",
+"message":  "Remove this empty class, write its code or make it an "interface".",
 "location":  {
 "uri":  "sources\akka.net\src\contrib\dependencyinjection\Akka.DI.TestKit\DiResolverSpec.cs",
 "region":  {

diff --git a/analyzers/its/expected/akka.net/Akka.MultiNodeTestRunner--net471-S2094.json b/analyzers/its/expected/akka.net/Akka.MultiNodeTestRunner--net471-S2094.json
@@ -2,7 +2,7 @@
 "issues":  [
 {
 "id":  "S2094",
-"message":  "Remove this empty class, or add members to it.",
+"message":  "Remove this empty class, write its code or make it an "interface".",
 "location":  {
 "uri":  "sources\akka.net\src\core\Akka.MultiNodeTestRunner\Program.cs",
 "region":  {
@@ -15,7 +15,7 @@
 },
 {
 "id":  "S2094",
-"message":  "Remove this empty class, or add members to it.",
+"message":  "Remove this empty class, write its code or make it an "interface".",
 "location":  {
 "uri":  "sources\akka.net\src\core\Akka.MultiNodeTestRunner\Program.cs",
 "region":  {

diff --git a/analyzers/its/expected/akka.net/Akka.MultiNodeTestRunner--net5.0-S2094.json b/analyzers/its/expected/akka.net/Akka.MultiNodeTestRunner--net5.0-S2094.json
@@ -2,7 +2,7 @@
 "issues":  [
 {
 "id":  "S2094",
-"message":  "Remove this empty class, or add members to it.",
+"message":  "Remove this empty class, write its code or make it an "interface".",
 "location":  {
 "uri":  "sources\akka.net\src\core\Akka.MultiNodeTestRunner\Program.cs",
 "region":  {
@@ -15,7 +15,7 @@
 },
 {
 "id":  "S2094",
-"message":  "Remove this empty class, or add members to it.",
+"message":  "Remove this empty class, write its code or make it an "interface".",
 "location":  {
 "uri":  "sources\akka.net\src\core\Akka.MultiNodeTestRunner\Program.cs",
 "region":  {

diff --git a/analyzers/its/expected/akka.net/Akka.MultiNodeTestRunner--netcoreapp3.1-S2094.json b/analyzers/its/expected/akka.net/Akka.MultiNodeTestRunner--netcoreapp3.1-S2094.json
@@ -2,7 +2,7 @@
 "issues":  [
 {
 "id":  "S2094",
-"message":  "Remove this empty class, or add members to it.",
+"message":  "Remove this empty class, write its code or make it an "interface".",
 "location":  {
 "uri":  "sources\akka.net\src\core\Akka.MultiNodeTestRunner\Program.cs",
 "region":  {
@@ -15,7 +15,7 @@
 },
 {
 "id":  "S2094",
-"message":  "Remove this empty class, or add members to it.",
+"message":  "Remove this empty class, write its code or make it an "interface".",
 "location":  {
 "uri":  "sources\akka.net\src\core\Akka.MultiNodeTestRunner\Program.cs",
 "region":  {