Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PhpCsFixer\Tokenizer\Tokens::setSize return type #7900

Merged
merged 2 commits into from Mar 19, 2024

Conversation

kubawerlos
Copy link
Contributor

@kubawerlos kubawerlos commented Mar 19, 2024

This time new error was:

Return type of PhpCsFixer\Tokenizer\Tokens::setSize($size): bool should either be compatible with SplFixedArray::setSize(int $size): true, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice

@coveralls
Copy link

Coverage Status

coverage: 96.034%. remained the same
when pulling e75b2b6 on 6b7562617765726c6f73:fix_php84
into 1eb4e52 on PHP-CS-Fixer:master.

@Wirone Wirone merged commit c066ecc into PHP-CS-Fixer:master Mar 19, 2024
25 checks passed
@Wirone Wirone deleted the fix_php84 branch March 19, 2024 17:47
@@ -287,6 +287,7 @@ public static function getBlockEdgeDefinitions(): array
*
* @param int $size
*/
#[\ReturnTypeWillChange]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the more of it we will have, the easier it will be for us if we have a todo with description when to drop this and apply the typing change in method header

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me todo is redundant here, we can prepare major upgrade checklist and put "review all #[ReturnTypeWillChange]" there 🙂.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easier for me to grep for @TODO than for @TODO|ReturnTypeWillChange|sthElseIAlreadyForgotWhatWasIt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants