Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: PhpCsFixer\Tokenizer\Tokens::setSize return type #7900

Merged
merged 2 commits into from Mar 19, 2024
Merged

fix: PhpCsFixer\Tokenizer\Tokens::setSize return type #7900

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
848171d
1
kubawerlos Mar 19, 2024
e75b2b6
2
kubawerlos Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Tokenizer/Tokens.php
View file
Open in desktop
Expand Up @@ -287,6 +287,7 @@ public static function getBlockEdgeDefinitions(): array
*
* @param int $size
*/
#[\ReturnTypeWillChange]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the more of it we will have, the easier it will be for us if we have a todo with description when to drop this and apply the typing change in method header

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me todo is redundant here, we can prepare major upgrade checklist and put "review all #[ReturnTypeWillChange]" there 🙂.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easier for me to grep for @TODO than for @TODO|ReturnTypeWillChange|sthElseIAlreadyForgotWhatWasIt

public function setSize($size): bool
{
if ($this->getSize() !== $size) {
Expand Down