Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: StatementIndentationFixer - do not crash on ternary operator in class property #7899

Merged

Conversation

kubawerlos
Copy link
Contributor

Fixes #7896

@coveralls
Copy link

coveralls commented Mar 19, 2024

Coverage Status

coverage: 96.035% (+0.001%) from 96.034%
when pulling f12282c on 6b7562617765726c6f73:fix_StatementIndentationFixer
into c066ecc on PHP-CS-Fixer:master.

@Wirone
Copy link
Member

Wirone commented Mar 19, 2024

That ParaUnit output is so meeeeehhhh 😩

@keradus
Copy link
Member

keradus commented Mar 19, 2024

mind to elaborate on your comment, @Wirone ?

@kubawerlos
Copy link
Contributor Author

I guess he means the failing job, it is extremely hard to see anything in the ParaUnit output.

@Wirone
Copy link
Member

Wirone commented Mar 19, 2024

Exactly what @kubawerlos said. Finding something meaningful on mobile in ParaUnit failed job output is kind of mission impossible 😩.

@kubawerlos
Copy link
Contributor Author

#7900 fixes the CI that fails here.

@Wirone Wirone force-pushed the fix_StatementIndentationFixer branch from 0b2f37d to f12282c Compare March 19, 2024 17:49
@Wirone Wirone enabled auto-merge (squash) March 19, 2024 17:51
@Wirone Wirone merged commit 5b7534c into PHP-CS-Fixer:master Mar 19, 2024
24 checks passed
@Wirone Wirone deleted the fix_StatementIndentationFixer branch March 19, 2024 17:56
@kenjis
Copy link

kenjis commented Mar 20, 2024

Thank you for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[InvalidArgumentException] Token at index xx is not the start of an alternative syntax block.
5 participants