Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert.Equal fails on Dictionary comparison with nullable types #2824

Closed
ladeak opened this issue Nov 20, 2023 · 4 comments
Closed

Assert.Equal fails on Dictionary comparison with nullable types #2824

ladeak opened this issue Nov 20, 2023 · 4 comments
Labels
area: Assertion library type: Bug

Comments

@ladeak
Copy link

ladeak commented Nov 20, 2023 •
edited

In xUnit (nuget package) 2.6.2 (compared to 2.6.1) Assert.Equal returns false for the following code:

Assert.Equal(new Dictionary<string, int?> { { "two", null } }, new Dictionary<string, int?> { { "two", null } });

while in 2.6.1 (and I think 'ever' before) it returned true.
@ladeak ladeak changed the title Assert.Equal fails on Dictionary comparison Assert.Equal fails on Dictionary comparison with nullable types Nov 20, 2023
amanda-tarafa added a commit to amanda-tarafa/google-cloud-dotnet that referenced this issue Nov 21, 2023
@amanda-tarafa
tests: Modify tests to account for XUnit issue.
d9abcaf 
Assert.Equal gives a false negative if dictionaries being compared contain null elements.

See xunit/xunit#2824
@amanda-tarafa amanda-tarafa mentioned this issue Nov 21, 2023
Merged
amanda-tarafa added a commit to googleapis/google-cloud-dotnet that referenced this issue Nov 21, 2023
@amanda-tarafa
tests: Modify tests to account for XUnit issue.
1ba60ae 
Assert.Equal gives a false negative if dictionaries being compared contain null elements.

See xunit/xunit#2824
bradwilson added a commit to xunit/assert.xunit that referenced this issue Nov 27, 2023
@bradwilson
xunit/xunit#2824: Assert.Equal fails with null values in dictionary
c35ef46
bradwilson added a commit that referenced this issue Nov 27, 2023
@bradwilson
Unit tests for #2824 (v3)
f01776f
bradwilson added a commit that referenced this issue Nov 27, 2023
@bradwilson
Unit tests for #2824 (v2)
62505d1
@bradwilson
Copy link
Member

Available in v2 2.6.3-pre.4
Available in v3 0.1.1-pre.327

@ladeak
Copy link
Author

ladeak commented Nov 27, 2023

thank you

@igurney-codat igurney-codat mentioned this issue Nov 27, 2023
Closed
@ladeak ladeak mentioned this issue Dec 5, 2023
Closed
@ladeak
Copy link
Author

ladeak commented Dec 5, 2023

@bradwilson when can we expect a non-preview build?

@bradwilson
Copy link
Member

@ladeak This week.

ViktorHofer added a commit to dotnet/arcade that referenced this issue Jan 19, 2024
@ViktorHofer
Squashed 'src/Microsoft.DotNet.XUnitAssert/src/' changes from cb1e33b…
0e3952e 
…a6..141681779

141681779 Missed #nullable enable in AsyncCollectionAsserts
22c89b0ea xunit/xunit#2367: Add IAsyncEnumerable<> overloads (.NET Core 3.0+)
d5c32630a While formatting type names in Assert.Equal/NotEqual, convert generated type names to '<generated>'
d7b807179 Add platform conditionals to support .NET 6 Roslyn Analyzers
6d9024665 xunit/xunit#2850: Assert.Equal failing value-slot collections of different concrete types (also fixed for KeyValuePair keys and values)
1f66b837a xunit/xunit#2811: Add SortedSet and ImmutableSortedSet overloads for Assert.Contains/DoesNotContain
1dab747d3 Update FuncEqualityComparer to throw if GetHashCode is called, and update EqualException/NotEqualException to process it
6e0a7cd70 xunit/xunit#2828: Prefer IEquatable<> over custom collection equality
c35ef46d5 xunit/xunit#2824: Assert.Equal fails with null values in dictionary
455865ac8 xunit/xunit#2821: Assert.Equal for collections of IEquatable objects don't call custom Equals
9af2c9c12 Clarify names for range comparer
2e6d9b267 Updates for .NET 8 SDK

git-subtree-dir: src/Microsoft.DotNet.XUnitAssert/src
git-subtree-split: 141681779e7638887a2ba711ad5407c67b6efe32
ViktorHofer added a commit to dotnet/arcade that referenced this issue Mar 28, 2024
@ViktorHofer
Squashed 'src/Microsoft.DotNet.XUnitAssert/src/' changes from cb1e33b…
a757c66 
…a6..574aebac4

574aebac4 xunit/xunit#2872: Expand special handling for sets in Assert.Contains/DoesNotContain
3b8edcbf1 xunit/xunit#2880: Update XML documentation for string-based Assert.Equal
d9f8361d2 Consolidate string and span-based Assert.Equal primary implementation
9ad71163e Move span-of-char assertions to StringAsserts and update docs/param names to indicate they're treated like strings
d70b34621 xunit/xunit#2871: Inner exception stack trace is missing from Assert.Collection failure
141681779 Missed #nullable enable in AsyncCollectionAsserts
22c89b0ea xunit/xunit#2367: Add IAsyncEnumerable<> overloads (.NET Core 3.0+)
d5c32630a While formatting type names in Assert.Equal/NotEqual, convert generated type names to '<generated>'
d7b807179 Add platform conditionals to support .NET 6 Roslyn Analyzers
6d9024665 xunit/xunit#2850: Assert.Equal failing value-slot collections of different concrete types (also fixed for KeyValuePair keys and values)
1f66b837a xunit/xunit#2811: Add SortedSet and ImmutableSortedSet overloads for Assert.Contains/DoesNotContain
1dab747d3 Update FuncEqualityComparer to throw if GetHashCode is called, and update EqualException/NotEqualException to process it
6e0a7cd70 xunit/xunit#2828: Prefer IEquatable<> over custom collection equality
c35ef46d5 xunit/xunit#2824: Assert.Equal fails with null values in dictionary
455865ac8 xunit/xunit#2821: Assert.Equal for collections of IEquatable objects don't call custom Equals
9af2c9c12 Clarify names for range comparer
2e6d9b267 Updates for .NET 8 SDK

git-subtree-dir: src/Microsoft.DotNet.XUnitAssert/src
git-subtree-split: 574aebac41dbbbf9e5e98bb9c65c6c5fab9b47f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: Assertion library type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bradwilson @ladeak