Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Modify tests to account for XUnit issue. #11350

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

amanda-tarafa
Copy link
Contributor

Assert.Equal gives a false negative if dictionaries being compared contain null elements.

See xunit/xunit#2824

Assert.Equal gives a false negative if dictionaries being compared contain null elements.

See xunit/xunit#2824
Copy link
Collaborator

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully we'll be able to undo this later :)

@amanda-tarafa
Copy link
Contributor Author

Hopefully we'll be able to undo this later :)

Yes!

@amanda-tarafa amanda-tarafa merged commit 1ba60ae into googleapis:main Nov 21, 2023
9 checks passed
@amanda-tarafa amanda-tarafa deleted the tests-failing branch November 21, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants