xunit/xunit#2824: Assert.Equal fails with null values in dictionary

xunit · Nov 27, 2023 · c35ef46 · c35ef46
1 parent 455865a
commit c35ef46
Showing 1 changed file with 9 additions and 8 deletions.
diff --git a/Sdk/CollectionTracker.cs b/Sdk/CollectionTracker.cs
@@ -183,16 +183,17 @@ protected CollectionTracker(IEnumerable innerEnumerable)
 
 				if (valueX == null)
 				{
-					if (valueY == null)
-						continue;
-					return false;
+					if (valueY != null)
+						return false;
 				}
-				if (valueY == null)
-					return false;
-
-				var comparer = AssertEqualityComparer.GetDefaultComparer(valueX.GetType());
-				if (!comparer.Equals(valueX, valueY))
+				else if (valueY == null)
 					return false;
+				else
+				{
+					var comparer = AssertEqualityComparer.GetDefaultComparer(valueX.GetType());
+					if (!comparer.Equals(valueX, valueY))
+						return false;
+				}
 
 				dictionaryYKeys.Remove(key);
 			}