Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tsconfig.json presets for TS 5.0 #7785

Merged
merged 4 commits into from Jul 26, 2023
Merged

Update tsconfig.json presets for TS 5.0 #7785

merged 4 commits into from Jul 26, 2023

Conversation

Princesseuh
Copy link
Member

Changes

TypeScript has this annoying behaviour where if you use an unknown compiler option, it'll.. completely refuse to do anything. I feel like they could've just added a warning instead, but whatever. This PR adds cool new options like verbatimModuleSyntax and updates it to use moduleResolution: 'bundler', unlocking supports for the exports field. It's neat

Testing

Tested manually

Docs

N/A, we don't document this

@changeset-bot
Copy link

changeset-bot bot commented Jul 24, 2023

🦋 Changeset detected

Latest commit: a956e4e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jul 24, 2023
…p people avoid weird bundling issues and save people time.
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be merged to the next branch?

@Princesseuh Princesseuh changed the base branch from main to next July 25, 2023 09:51
@ematipico ematipico force-pushed the next branch 2 times, most recently from 1be3605 to d8ae80b Compare July 26, 2023 12:46
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, let's 🚢 it!

@Princesseuh Princesseuh merged commit fdc22ff into next Jul 26, 2023
7 of 8 checks passed
@Princesseuh Princesseuh deleted the feat/5.0-tsconfig branch July 26, 2023 13:13
ematipico pushed a commit that referenced this pull request Jul 26, 2023
ematipico pushed a commit that referenced this pull request Jul 27, 2023
ematipico pushed a commit that referenced this pull request Jul 31, 2023
ematipico pushed a commit that referenced this pull request Aug 1, 2023
ematipico pushed a commit that referenced this pull request Aug 1, 2023
ematipico pushed a commit that referenced this pull request Aug 3, 2023
ematipico pushed a commit that referenced this pull request Aug 8, 2023
@howagain
Copy link

I'm seeing a behavior on webstorm where "allowImportingTsExtensions": true is adding the .tsx extension automatically. It seems like a bug on their side but why is it included in the base tsConfig for astro? I don't see any discussion over that decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants