chore: Update docs for TS 5 presets #9025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
added
the
pkg: astro
natemoo-re
approved these changes
Nov 9, 2023
natemoo-re
added a commit
that referenced
this pull request
Nov 22, 2023
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
My change updates the comment for the
moduleResolutionsetting as this setting has been changed in #7785The current comment says it enables "node-style module resolution" but the resolution value got changed from
nodetoBundlerand the TypeScript's moduleResolution documentation says that this change has a major difference which I think is worth being mentioned:Testing
It's only updating the comment, no behaviour change gets introduced.
Docs
/cc @withastro/maintainers-docs for feedback!