Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle package self-referencing in shared module #16685

Merged
merged 2 commits into from Apr 5, 2023
Merged

fix: handle package self-referencing in shared module #16685

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e559f15
fix: handle package self-referencing in shared module
weareoutman Jan 31, 2023
be8b1a1
add test case for package self referencing
weareoutman Feb 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/sharing/ConsumeSharedPlugin.js
View file
Open in desktop
Expand Up @@ -224,6 +224,10 @@ class ConsumeSharedPlugin {
);
return resolve();
}
if (data.name === packageName) {
// Package self-referencing
return resolve();
}
const requiredVersion = getRequiredVersionFromDescriptionFile(
data,
packageName
Expand Down