Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle package self-referencing in shared module #16685

Merged
merged 2 commits into from Apr 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/sharing/ConsumeSharedPlugin.js
Expand Up @@ -224,6 +224,10 @@ class ConsumeSharedPlugin {
);
return resolve();
}
if (data.name === packageName) {
// Package self-referencing
return resolve();
}
const requiredVersion = getRequiredVersionFromDescriptionFile(
data,
packageName
Expand Down
4 changes: 4 additions & 0 deletions test/configCases/sharing/consume-self-reference/index.js
@@ -0,0 +1,4 @@
it("should be able to consume package self referencing", async () => {
const result = await import("my-middleware");
expect(result.m()).toBe("ABA");
});

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions test/configCases/sharing/consume-self-reference/package.json
@@ -0,0 +1,5 @@
{
"dependencies": {
"my-middleware": "^2.3.0"
}
}
26 changes: 26 additions & 0 deletions test/configCases/sharing/consume-self-reference/webpack.config.js
@@ -0,0 +1,26 @@
// eslint-disable-next-line node/no-unpublished-require
const { SharePlugin } = require("../../../../").sharing;

/** @type {import("../../../../").Configuration} */
module.exports = {
plugins: [
new SharePlugin({
shared: {
"my-middleware": {
singleton: true
// import: false
},
"my-module/a": {
singleton: true,
version: "1.2.3"
// import: false
},
"my-module/b": {
singleton: true,
version: "1.2.3"
// import: false
}
}
})
]
};