Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app(IN-941): Search page alerts #1182
base: dev
Are you sure you want to change the base?
app(IN-941): Search page alerts #1182
Changes from 9 commits
4364c13
9b9875c
ac4221b
40598eb
4f834a3
b531d61
18e8976
aa9b9dc
a6def0e
3541264
cb38c78
981d651
f0f4a3b
1fc8cdb
abafc40
8faeb20
03023a9
7b71fbd
a2338f0
18b2915
ea37be5
171f56a
0812bc5
db6503f
1270e46
288705a
6d1b9f3
98205f3
3d64306
22f43da
c51d503
7d86903
e8d0c24
fa78947
c6a4d78
045b747
563259b
50223a9
62441be
f1a45d9
9ae63e3
640193f
7841e80
4dcb3ab
c0a24cb
91c5d39
1f3c3a0
c367eb7
85a65e3
a650d1d
1fa9cd0
529d029
914c4a9
0ebad05
1792e3d
8e93bd1
40d2433
f62ade6
3193b46
6744e14
f4ef6a8
9172728
dd58a33
ba5257b
e7f2264
b90e7d8
2ceae23
f7e16dd
69c1452
ff59167
0d4b97e
3968a3e
9995efe
b05e0d0
bc0941f
419c039
a43ef77
3ff8f60
5ba4e46
aa8f4f8
d4f2875
f1e34a2
6ebfd7c
14f43d4
4db914d
7acf791
38928ea
4a7f4ba
72cb89b
0b1aeec
a9a1d6e
4308735
475030d
39415d0
f4e9277
a3307cb
e7b56bb
9969e7f
bf83dcb
4a157dc
74c1ee8
d1660ff
d7ce6d4
807bf0d
83fe74d
8e701ff
61aa216
bc80afe
6c10984
d464dd7
9cf88ea
151173e
812c70e
44a327a
1529af8
d8a1abd
8f01aea
84b92d5
985da6d
069f289
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refine logic to determine state from search term.
Consider using a more robust method to parse the location information from the search term, as the current method may not handle all cases effectively.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we extract the banner code out in to a separate component?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes good call, I'll work on that this week!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would the banners go in the story book as components?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, you can create it in
components/core
in the ui package - there are plenty of*.stories.tsx
files to use as a starting template.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved the banners to components although my folder structure may be a bit different, was having an issue with imports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed part of it - you were trying to move the component in to a storybook file (
*.stories.tsx
shouldn't get imported in to any functional part of the app - those are for Storybook only). I moved the component toui/components/core/LocationBasedAlertBanner/index.tsx
and set up 3 different use examples. Inside the storybook file, in theRenderWrapper
component I put in there (just for purposes of pulling mock API data), you'll see how the API call is done. The API can return more than one result, in the event that there are multiple alerts for an area or overlapping alertsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't touch the implementation on this page though -- that still needs to be done
Check warning on line 31 in packages/ui/modals/ServiceFilter/index.tsx
InReachBot / Check Code for Errors
packages/ui/modals/ServiceFilter/index.tsx#L31
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I chose the light green based on this https://m2.material.io/design/color/the-color-system.html#tools-for-picking-colors
This was not in the design, so not sure if we want to use this instead of the lightPink for all states.