app(IN-941): Search page alerts #1182
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
github-actions
bot
added
automerge
| @@ -43,6 +43,77 @@ const ServiceFilter = dynamic(() => | |||
| import('@weareinreach/ui/modals/ServiceFilter').then((mod) => mod.ServiceFilter) | |||
| ) | |||
|
|
|||
| const stateRiskLevels = { | |||
There was a problem hiding this comment.
Sorry this is a bit ugly, I could do 4 arrays and then build some logic if else statements, not sure.
| @@ -63,6 +63,8 @@ const colors = { | |||
| coolGray: '#d9d9d9', | |||
| red: '#C05C4A', | |||
| pink: '#D4A1BA', | |||
| lightPink: '#F2E1E9', | |||
| lightGreen: '#E4F9EA', | |||
There was a problem hiding this comment.
I chose the light green based on this https://m2.material.io/design/color/the-color-system.html#tools-for-picking-colors
This was not in the design, so not sure if we want to use this instead of the lightPink for all states.
📦 Next.js Bundle Analysis for @weareinreach/appThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
| </Text> | ||
| </Box> | ||
| )} | ||
|
|
There was a problem hiding this comment.
Can we extract the banner code out in to a separate component?
There was a problem hiding this comment.
Yes good call, I'll work on that this week!
There was a problem hiding this comment.
Would the banners go in the story book as components?
There was a problem hiding this comment.
Yeah, you can create it in components/core in the ui package - there are plenty of *.stories.tsx files to use as a starting template.
There was a problem hiding this comment.
Moved the banners to components although my folder structure may be a bit different, was having an issue with imports
There was a problem hiding this comment.
I fixed part of it - you were trying to move the component in to a storybook file (*.stories.tsx shouldn't get imported in to any functional part of the app - those are for Storybook only). I moved the component to ui/components/core/LocationBasedAlertBanner/index.tsx and set up 3 different use examples. Inside the storybook file, in the RenderWrapper component I put in there (just for purposes of pulling mock API data), you'll see how the API call is done. The API can return more than one result, in the event that there are multiple alerts for an area or overlapping alerts
There was a problem hiding this comment.
I didn't touch the implementation on this page though -- that still needs to be done
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
Signed-off-by: Joe Karow <58997957+JoeKarow@users.noreply.github.com>
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@types/ms@0.7.34, npm/@types/node@16.18.97, npm/@types/yargs@17.0.32, npm/dotenv@16.4.5, npm/prettier@3.2.5, npm/zod@3.23.8 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/db/prisma/schema.prisma (4 hunks)
Additional comments not posted (5)
packages/db/prisma/schema.prisma (5)
781-781: AddedLocationAlertrelation toFreeTextmodel.Ensure that the
LocationAlertmodel is properly defined elsewhere in the schema to support this relation.
1303-1303: AddedLocationAlertrelation toCountrymodel.Verify that the
LocationAlertmodel is correctly implemented and that the relation is consistent with the application's requirements.
1356-1356: AddedLocationAlertrelation toGovDistmodel.Confirm that the
LocationAlertmodel is correctly set up and that this relation is necessary for the functionality of the application.
1408-1430: Introduced a new modelLocationAlertwith fieldsid,active,text,level,country, andgovDist.This model is crucial for the new feature of dynamic location-based alerts. Ensure that all fields are correctly used in the application logic and that the relations (
countryandgovDist) are properly indexed for performance.
1426-1430: Defined new enumLocationAlertLevelwith valuesINFO,WARN, andCRITICAL.This enum is essential for categorizing the severity of location alerts. Ensure that the application logic correctly handles these levels.
|
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: IN-941
What is the new behavior?
Does this introduce a breaking change?
Other information
Screen.Recording.2024-03-22.at.1.45.15.PM.mov
Summary by CodeRabbit
New Features
Enhancements
lightPinkandlightGreen) to improve visual elements.Bug Fixes
Documentation