Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(markdown): fix query parsing and absolute link fallback in linksPlugin (close #1536) #1537

Merged
merged 5 commits into from May 16, 2024
Merged

fix(markdown): fix query parsing and absolute link fallback in linksPlugin (close #1536) #1537

merged 5 commits into from May 16, 2024

Conversation

Mister-Hope
Copy link
Member

@Mister-Hope Mister-Hope commented Apr 11, 2024 •
edited by meteorlxy

Closes #1536

  • Now queries are preserved instead of being removed
  • Absolute link is null when a link is relative and there is no markdown file info

This PR is based on #1521

@Mister-Hope Mister-Hope linked an issue Apr 11, 2024 that may be closed by this pull request
[Bug report] linkPlugin can not handle query #1536
Closed
@coveralls
Copy link

coveralls commented Apr 11, 2024 •
edited

Pull Request Test Coverage Report for Build 9093050179

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 41.096%
Totals Coverage Status
Change from base Build 9088295155: 0.09%
Covered Lines: 688
Relevant Lines: 1716
💛 - Coveralls

@Mister-Hope Mister-Hope mentioned this pull request Apr 11, 2024
Open
meteorlxy
meteorlxy requested changes May 14, 2024
View reviewed changes
Copy link
Member

@meteorlxy meteorlxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update test cases

@meteorlxy meteorlxy changed the title fix(markdown): fix linksPlugin parsing query and wrong absolute link fix(markdown): fix linksPlugin parsing query and wrong absolute link (close #1536) May 14, 2024
@meteorlxy meteorlxy changed the title fix(markdown): fix linksPlugin parsing query and wrong absolute link (close #1536) fix(markdown): fix query parsing and absolute link fallback in linksPlugin (close #1536) May 14, 2024
@Mister-Hope

This comment has been minimized.

Sign in to view
@Mister-Hope Mister-Hope requested review from meteorlxy and removed request for meteorlxy May 15, 2024 15:59
@meteorlxy meteorlxy merged commit 5082b3d into main May 16, 2024
30 checks passed
@meteorlxy meteorlxy deleted the markdown-links branch May 16, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorlxy meteorlxy meteorlxy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug report] linkPlugin can not handle query
3 participants
@Mister-Hope @coveralls @meteorlxy