Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add route option (close #1505) #1538

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: add route option (close #1505) #1538

wants to merge 7 commits into from

Conversation

Mister-Hope
Copy link
Member

@Mister-Hope Mister-Hope commented Apr 11, 2024 •
edited

This pr adds route option for vuepress config file.

  • New cleanUrl option to support "clean urls" without .html suffix
  • pagePatterns and permalinkPatten is moved under route

This pr is based on #1537

@Mister-Hope Mister-Hope linked an issue Apr 11, 2024 that may be closed by this pull request
[Feature request] CleanUrl #1505
Open
@meteorlxy meteorlxy changed the title feat: add route option feat: add route option (close #1505) May 14, 2024
@coveralls
Copy link

coveralls commented May 16, 2024 •
edited

Pull Request Test Coverage Report for Build 9105486644

Details

  • 11 of 15 (73.33%) changed or added relevant lines in 8 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 41.338%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/cli/src/commands/dev/watchPageFiles.ts 0 1 0.0%
packages/client/src/router/resolveRoutePath.ts 0 1 0.0%
packages/core/src/app/prepare/prepareRoutes.ts 1 3 33.33%
Files with Coverage Reduction New Missed Lines %
packages/client/src/router/resolveRoutePath.ts 1 0.0%
packages/core/src/app/prepare/prepareRoutes.ts 1 10.34%
Totals Coverage Status
Change from base Build 9104606222: 0.2%
Covered Lines: 692
Relevant Lines: 1720
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorlxy meteorlxy Awaiting requested review from meteorlxy

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature request] CleanUrl
3 participants
@Mister-Hope @coveralls @meteorlxy