Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(effect): computed lost reactivity #10119

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

Doctor-wu
Copy link
Contributor

@Doctor-wu Doctor-wu commented Jan 15, 2024

close #10114
This PR will re-introduce the problem of #10085, #10090, but the computed would not lose reactivity
I think this might be a trade-off in short term.

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 89.8 kB (+32 B) 34.2 kB (+2 B) 30.8 kB (-1 B)
vue.global.prod.js 147 kB (+32 B) 53.5 kB (+2 B) 47.8 kB (+46 B)

Usages

Name Size Gzip Brotli
createApp 50.2 kB (+32 B) 19.6 kB (+2 B) 18 kB (+58 B)
createSSRApp 53.5 kB (+32 B) 21 kB (+3 B) 19.1 kB (-10 B)
defineCustomElement 52.5 kB (+32 B) 20.4 kB (+3 B) 18.6 kB (-11 B)
overall 63.9 kB (+32 B) 24.7 kB (+2 B) 22.4 kB (+41 B)

@Doctor-wu
Copy link
Contributor Author

Doctor-wu commented Jan 15, 2024

@yyx990803 @LinusBorg Could you help to invoke the ecosystem ci, to prevent this will cause some complex cases to fail

@Doctor-wu Doctor-wu marked this pull request as ready for review January 15, 2024 14:53
@yyx990803
Copy link
Member

/ecosystem-ci run

@yyx990803
Copy link
Member

yyx990803 commented Jan 15, 2024

Can you add a test case similar this this? nvm, the changed test case already does

@Doctor-wu Doctor-wu changed the title fix(effect): computed lost dirty fix(effect): computed lost reactivity Jan 15, 2024
@vue-bot
Copy link

vue-bot commented Jan 15, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure failure
nuxt success success
pinia success success
quasar failure success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify success success
vueuse success success
vue-simple-compiler success success

@yyx990803
Copy link
Member

Looks like the quasar fail is a flaky transition test. Re-running to be sure.

@Doctor-wu
Copy link
Contributor Author

The test seems to have passed, but the comment update failed😂

@yyx990803 yyx990803 merged commit 20f62af into vuejs:main Jan 15, 2024
11 checks passed
@Doctor-wu Doctor-wu deleted the fix-computed-dirty-level branch January 15, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reactive fail on 3.4.13
3 participants