Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reactivity): the scheduler handles the computed final dirtylevel #10120

Closed
wants to merge 1 commit into from

Conversation

yangxiuxiu1115
Copy link
Contributor

fix #10114 , In computed use scheduler to process the final dirtylevel.Locally I passed all the test cases. Perhaps a deeper test is needed

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 89.8 kB (+47 B) 34.2 kB (+13 B) 30.8 kB (+12 B)
vue.global.prod.js 147 kB (+47 B) 53.5 kB (+13 B) 47.7 kB (-13 B)

Usages

Name Size Gzip Brotli
createApp 50.2 kB (+47 B) 19.6 kB (+11 B) 17.9 kB (+8 B)
createSSRApp 53.6 kB (+47 B) 21 kB (+11 B) 19.1 kB (-1 B)
defineCustomElement 52.5 kB (+47 B) 20.4 kB (+11 B) 18.6 kB (-22 B)
overall 63.9 kB (+47 B) 24.7 kB (+8 B) 22.4 kB (+36 B)

@yyx990803
Copy link
Member

/ecosystem-ci run

@vue-bot
Copy link

vue-bot commented Jan 15, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure failure
nuxt success success
pinia success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify success success
vueuse success success
vue-simple-compiler success success

@yyx990803
Copy link
Member

I think #10119 is the slightly better fix but thanks for the PR!

@yyx990803 yyx990803 closed this Jan 15, 2024
@yangxiuxiu1115 yangxiuxiu1115 deleted the fix/computed branch January 15, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reactive fail on 3.4.13
3 participants