fix(cli): parse --browser=<name> correctly

[AriPerkkio]

Description

• Fixes refactor: add CLI config schema to make sure we don't miss options #5126 (comment)

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

• It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
• Ideally, include a test that fails without this PR but passes with it.
• Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

• Run the tests with pnpm test:ci.

Documentation

• If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

• Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

[netlify]

✅ Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name	Link
🔨 Latest commit	4e6ba96
🔍 Latest deploy log	https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/65c9b3b47f1a38000815ebcb

[AriPerkkio]

/ecosystem-ci run

[vitest-ecosystem-ci]

📝 Ran ecosystem CI: Open

suite	result
nuxt	✅ success
nuxt-test-utils	✅ success
vite	✅ success
vitest-sonar-reporter	✅ success
vitest-github-actions-reporter	✅ success
vitest-browser-simple	✅ success
vitest-coverage-large	✅ success
vitest-reporters-large	✅ success

[hi-ogawa]

I wonder how these case are handled now (and also before).

• --browser=false
• --browser false
• --browser some-file.test.ts

Can you include these in tests?

[AriPerkkio]

Added test cases for the --browser=false and --browser false. Not sure how --browser some-file.test.ts could be supported though.

[hi-ogawa]

Just to clarify, I wasn't saying to support something like --browser some-file.test.ts but I was simply wondering the current and previous behaviors.

I would imagine it would be tricky to support that, so it's probably okay to treat it as { name: "some-file.test.ts" } for now?

[AriPerkkio]

Looks like it doesn't work with the latest release either. Let's not do changes related to that for now. I'll revert that test case.

$ vitest --browser app.spec.ts

 DEV  v1.2.2 /x/y/z/browser-simple
      Browser runner started at http://localhost:5173/


⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Unhandled Error ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Error: [] Browser "app.spec.ts" is not supported by the browser provider "playwright". Supported browsers: firefox, webkit, chromium.

[hi-ogawa]

Maybe revert true/false handling too? It looks like it wasn't supported in the last release.

[sheremet-va]

Maybe revert true/false handling too? It looks like it wasn't supported in the last release.

It was clearly a bug, and one of the reasons we are making changes to the CLI parsing is to fix those edge cases.