fix(cli): parse --browser=<name> correctly

vitest-dev · Feb 12, 2024 · fa65648 · fa65648
1 parent 78156f7
commit fa65648
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 3 deletions.
diff --git a/packages/vitest/src/node/cli/cli-config.ts b/packages/vitest/src/node/cli/cli-config.ts
@@ -303,10 +303,12 @@ export const cliOptionsConfig: VitestCLIOptions = {
   },
   browser: {
     description: 'Run tests in the browser. Equivalent to --browser.enabled (default: false)',
-    argument: '', // allow boolean
+    argument: '<name>',
     transform(browser) {
       if (typeof browser === 'boolean')
         return { enabled: browser }
+      if (browser === 'true' || browser === 'false')
+        return { enabled: browser !== 'false' }
       if (typeof browser === 'string')
         return { enabled: true, name: browser }
       return browser

diff --git a/test/core/test/cli-test.test.ts b/test/core/test/cli-test.test.ts
@@ -222,15 +222,34 @@ test('cache is parsed correctly', () => {
   })
 })
 
-test('browser as boolean', () => {
+test('browser as implicit boolean', () => {
   const { options, args } = parseArguments('--browser', false, true)
   expect(options).toEqual({ browser: { enabled: true } })
   expect(args).toEqual([])
 })
 
-test('browser as string', () => {
+test('browser as explicit boolean', () => {
+  const { options, args } = parseArguments('--browser=true', false, true)
+  expect(options).toEqual({ browser: { enabled: true } })
+  expect(args).toEqual([])
+})
+
+test('browser as explicit boolean with space', () => {
+  const { options, args } = parseArguments('--browser true', false, true)
+  expect(options).toEqual({ browser: { enabled: true } })
+  expect(args).toEqual([])
+})
+
+test('browser by name', () => {
   const { options, args } = parseArguments('--browser=firefox', false, true)
 
   expect(args).toEqual([])
   expect(options).toEqual({ browser: { enabled: true, name: 'firefox' } })
 })
+
+test('browser as boolean with file filter', () => {
+  const { options, args } = parseArguments('--browser some-file.test.ts', false, true)
+
+  expect(args).toEqual(['some-file.test.ts'])
+  expect(options).toEqual({ browser: { enabled: true } })
+})