Do not rewrite last_insert_id function calls with arguments.

[arthurschreiber]

Description

With Vitess v16, the rewriting behaviour of last_insert_id and other function calls became more strict. It explicitly returns an error now when last_insert_id is called with an argument, whereas before it would just not perform any rewriting and pass the function call to MySQL as-is.

This change restores the previous behaviour of not rewriting last_insert_id funciton calls that have arguments.

Related Issue(s)

N/A

Checklist

• "Backport to:" labels have been added if this change should be back-ported
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on the CI
• Documentation was added or is not required

Deployment Notes

N/A

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
• If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

• Is it really necessary to add this flag?
• Flag names should be clear and intuitive (as far as possible)
• Help text should be descriptive.
• Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow should be required, the maintainer team should be notified.

Bug fixes

• There should be at least one unit or end-to-end test.
• The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

• There should be some code comments as to why things are implemented the way they are.

New/Existing features

• Should be documented, either by modifying the existing documentation or creating new documentation.
• New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• vtctl command output order should be stable and awk-able.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from VTop, if used there.

[dbussink]

@arthurschreiber Can you also write up an issue for this specific regression?

[harshit-gangal]

Earlier we were writing the error in the rewrite struct type astRewriter struct and were not checking that error.
Now, we are returning this which is causing the regression. So, the fix above is not sufficient for the regression to be called fixed.

[arthurschreiber]

Earlier we were writing the error in the rewrite struct type astRewriter struct and were not checking that error.
Now, we are returning this which is causing the regression. So, the fix above is not sufficient for the regression to be called fixed.

@harshit-gangal Can you elaborate on that? I'm not sure I understand what is missing here. 😞 I tested the fix against our codebase and it seems to be working as expected?

[systay]

Replaced by #13026