Bug Report: last_insert_id with argument broken starting Vitess 16.0.0

[arthurschreiber]

Overview of the Issue

After bumping Vitess to v16 in our CI system, we noticed that the behaviour of last_insert_id with an argument has changed between Vitess v15 and Vitess v16.

In Vitess v15, on a sharded keyspace, calling last_insert_id with an argument to explicitly set the session's last_insert_id value "just worked" - the mysql response's last_insert_id would be set to the correct value, and calling last_insert_id in a followup query would return the value that was previously set.

In Vitess v16, doing the same on a sharded keyspace started returning a "Argument to last_insert_id() not supported" error.

The query we run in production looks something like this:

UPDATE `some_table` SET `foo` = LAST_INSERT_ID(`foo` + 1) WHERE id = 12345

Reproduction Steps

N/A

Binary Version

16.0.1

Operating System and Environment details

N/A

Log Fragments

No response

[arthurschreiber]

See #12997 for a potential fix.