New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix purity lint for CSS Modules in swc mode #7621
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
✅ This change can build |
|
sokra
reviewed
Mar 5, 2024
sokra
reviewed
Mar 5, 2024
sokra
reviewed
Mar 5, 2024
sokra
reviewed
Mar 5, 2024
Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
sokra
approved these changes
Mar 6, 2024
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 7, 2024
# Turbopack * vercel/turbo#7625 <!-- Tobias Koppers - generate calls of bindings correctly without this context --> * vercel/turbo#7621 <!-- Donny/강동윤 - fix: Fix purity lint for CSS Modules in swc mode --> * vercel/turbo#7640 <!-- Tobias Koppers - very dynamic requests will only lead to a warning --> * vercel/turbo#7639 <!-- Donny/강동윤 - build: Update `swc_core` to `v0.90.17` --> ### What? Update turbopack ### Why? To keep in sync ### How?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes PACK-2660
Testing Instructions
I added a test.