Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update turbopack #62971

Merged
merged 2 commits into from Mar 7, 2024
Merged

Update turbopack #62971

merged 2 commits into from Mar 7, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Mar 7, 2024

@kdy1 kdy1 self-assigned this Mar 7, 2024
@ijjk ijjk added created-by: Turbopack team PRs by the turbopack team type: next labels Mar 7, 2024
@socket-security Socket Security
Copy link

socket-security bot commented Mar 7, 2024 •
edited

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
CVE npm/json5@0.5.1
CVE npm/json5@2.2.0
Deprecated npm/@babel/plugin-proposal-dynamic-import@7.16.7
  • Reason: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-dynamic-import instead.
Deprecated npm/@babel/plugin-proposal-logical-assignment-operators@7.16.7
  • Reason: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-logical-assignment-operators instead.
Deprecated npm/@babel/plugin-proposal-private-methods@7.16.11
  • Reason: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-private-methods instead.
Deprecated npm/@babel/plugin-proposal-private-property-in-object@7.16.7
  • Reason: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-private-property-in-object instead.
Deprecated npm/@playwright/test@1.19.2
  • Reason: Please update to the latest version of Playwright to test up-to-date browsers.
CVE npm/jpeg-js@0.4.3

View full report↗︎

Next steps

What is a CVE?

Contains a high severity Common Vulnerability and Exposure (CVE).

Remove or replace dependencies that include known high severity CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

What is a deprecated package?

The maintainer of the package marked it as deprecated. This could indicate that a single version should not be used, or that the package is no longer maintained and any new vulnerabilities will not be fixed.

Research the state of the package and determine if there are non-deprecated versions that can be used, or if it should be replaced with a new, supported solution.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/json5@0.5.1
  • @SocketSecurity ignore npm/json5@2.2.0
  • @SocketSecurity ignore npm/@babel/plugin-proposal-dynamic-import@7.16.7
  • @SocketSecurity ignore npm/@babel/plugin-proposal-logical-assignment-operators@7.16.7
  • @SocketSecurity ignore npm/@babel/plugin-proposal-private-methods@7.16.11
  • @SocketSecurity ignore npm/@babel/plugin-proposal-private-property-in-object@7.16.7
  • @SocketSecurity ignore npm/@playwright/test@1.19.2
  • @SocketSecurity ignore npm/jpeg-js@0.4.3

@ijjk
Copy link
Member

ijjk commented Mar 7, 2024 •
edited

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js kdy1/update-turbopack-3 Change
buildDuration 13.9s 13.7s N/A
buildDurationCached 7.4s 6.1s N/A
nodeModulesSize 198 MB 198 MB ⚠️ +22.3 kB
nextStartRea..uration (ms) 431ms 437ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js kdy1/update-turbopack-3 Change
2453-HASH.js gzip 30.5 kB 30.5 kB N/A
3304.HASH.js gzip 181 B 181 B ✓
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB N/A
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB ✓
main-app-HASH.js gzip 242 B 243 B N/A
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 45.4 kB 45.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js kdy1/update-turbopack-3 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js kdy1/update-turbopack-3 Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B ✓
amp-HASH.js gzip 505 B 505 B ✓
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B ✓
head-HASH.js gzip 352 B 352 B ✓
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.21 kB 4.21 kB ✓
index-HASH.js gzip 259 B 259 B ✓
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 6.57 kB 6.57 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js kdy1/update-turbopack-3 Change
_buildManifest.js gzip 481 B 484 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js kdy1/update-turbopack-3 Change
index.html gzip 529 B 529 B ✓
link.html gzip 541 B 542 B N/A
withRouter.html gzip 524 B 523 B N/A
Overall change 529 B 529 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js kdy1/update-turbopack-3 Change
edge-ssr.js gzip 95.1 kB 95.1 kB N/A
page.js gzip 3.07 kB 3.07 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js kdy1/update-turbopack-3 Change
middleware-b..fest.js gzip 626 B 625 B N/A
middleware-r..fest.js gzip 151 B 151 B ✓
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B ✓
Overall change 990 B 990 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js kdy1/update-turbopack-3 Change
app-page-exp...dev.js gzip 171 kB 171 kB ✓
app-page-exp..prod.js gzip 96.5 kB 96.5 kB ✓
app-page-tur..prod.js gzip 98.2 kB 98.2 kB ✓
app-page-tur..prod.js gzip 92.7 kB 92.7 kB ✓
app-page.run...dev.js gzip 149 kB 149 kB ✓
app-page.run..prod.js gzip 91.2 kB 91.2 kB ✓
app-route-ex...dev.js gzip 21.3 kB 21.3 kB ✓
app-route-ex..prod.js gzip 15 kB 15 kB ✓
app-route-tu..prod.js gzip 15 kB 15 kB ✓
app-route-tu..prod.js gzip 14.8 kB 14.8 kB ✓
app-route.ru...dev.js gzip 20.9 kB 20.9 kB ✓
app-route.ru..prod.js gzip 14.8 kB 14.8 kB ✓
pages-api-tu..prod.js gzip 9.52 kB 9.52 kB ✓
pages-api.ru...dev.js gzip 9.8 kB 9.8 kB ✓
pages-api.ru..prod.js gzip 9.52 kB 9.52 kB ✓
pages-turbo...prod.js gzip 22.3 kB 22.3 kB ✓
pages.runtim...dev.js gzip 22.9 kB 22.9 kB ✓
pages.runtim..prod.js gzip 22.3 kB 22.3 kB ✓
server.runti..prod.js gzip 50.5 kB 50.5 kB ✓
Overall change 947 kB 947 kB ✓
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js kdy1/update-turbopack-3 Change
0.pack gzip 1.56 MB 1.56 MB ⚠️ +623 B
index.pack gzip 106 kB 106 kB N/A
Overall change 1.56 MB 1.56 MB ⚠️ +623 B
Diff details
Diff for middleware.js

Diff too large to display

Commit: 630ba27

@ijjk
Copy link
Member

ijjk commented Mar 7, 2024 •
edited

Tests Passed

@sokra sokra merged commit 03d89bc into canary Mar 7, 2024
67 of 68 checks passed
@sokra sokra deleted the kdy1/update-turbopack-3 branch March 7, 2024 13:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sokra sokra sokra approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@feedthejim feedthejim Awaiting requested review from feedthejim feedthejim is a code owner

@ztanner ztanner Awaiting requested review from ztanner ztanner is a code owner

@wyattjoh wyattjoh Awaiting requested review from wyattjoh wyattjoh is a code owner

Assignees

@kdy1 kdy1

Labels
created-by: Turbopack team PRs by the turbopack team locked type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kdy1 @ijjk @sokra