Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix purity lint for CSS Modules in swc mode #7621

Merged
merged 12 commits into from Mar 6, 2024
Merged

fix: Fix purity lint for CSS Modules in swc mode #7621

merged 12 commits into from Mar 6, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Mar 5, 2024

Description

Closes PACK-2660

Testing Instructions

I added a test.

@kdy1 kdy1 self-assigned this Mar 5, 2024
@kdy1 kdy1 requested a review from a team as a code owner March 5, 2024 04:54
@vercel Vercel
Copy link

vercel bot commented Mar 5, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2024 5:03am
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2024 5:03am
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2024 5:03am
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2024 5:03am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2024 5:03am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2024 5:03am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2024 5:03am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2024 5:03am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2024 5:03am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2024 5:03am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024 •
edited

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024

✅ This change can build next-swc

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024 •
edited

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@kdy1 @sokra
Update crates/turbopack-css/src/process.rs
ee5651d 
Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
@kdy1 kdy1 requested a review from sokra March 6, 2024 04:21
@kdy1 kdy1 merged commit ce591fd into main Mar 6, 2024
49 of 51 checks passed
@kdy1 kdy1 deleted the kdy1/pack-2660 branch March 6, 2024 08:13
@kdy1 kdy1 mentioned this pull request Mar 7, 2024
Merged
sokra pushed a commit to vercel/next.js that referenced this pull request Mar 7, 2024
@kdy1
Update turbopack (#62971)
03d89bc 
# Turbopack

* vercel/turbo#7625 <!-- Tobias Koppers -
generate calls of bindings correctly without this context -->
* vercel/turbo#7621 <!-- Donny/강동윤 - fix: Fix
purity lint for CSS Modules in swc mode -->
* vercel/turbo#7640 <!-- Tobias Koppers - very
dynamic requests will only lead to a warning -->
* vercel/turbo#7639 <!-- Donny/강동윤 - build:
Update `swc_core` to `v0.90.17` -->


### What?

Update turbopack

### Why?

To keep in sync

### How?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

Assignees

@kdy1 kdy1

Labels
created-by: turbopack owned-by: turbopack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kdy1 @sokra