-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse reference datetime and timedelta from the same string #110
Conversation
805611a
to
52e0546
Compare
Great to see you also fixed the failing |
Sorry, I don't know how to interpret the "Basic CI / Run the fuzzers" job failure. Let me know if I should do anything about that. |
I'll extract some of these changes into smaller pull requests. |
I'm still in the process of breaking this down into smaller changesets. A few more pull requests have been made. |
Change the `parse_datetime()` function so that it parses both a reference date and a time delta from one string. The new implementation attempts to parse the datetime from the longest possible prefix of the string. The remainder of the string is parsed as the time delta. This allows us to parse more combinations of reference dates and time deltas more easily. Fixes uutils#104
e9f9b45
to
8aee979
Compare
Thanks for your patience. We've now merged quite a few smaller pull requests comprising changes extracted from this branch. I've now rebased on |
Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. |
Thanks for splitting it into multiple PRs, much appreciated :) |
Change the
parse_datetime()
function so that it parses both areference date and a time delta from one string. The new implementation
attempts to parse the datetime from the longest possible prefix of the
string. The remainder of the string is parsed as the time delta. This
allows us to parse more combinations of reference dates and time deltas
more easily.
Fixes #104