Greedy parsing of datetime before time delta #115
Merged
+126
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a passing unit test for parsing a datetime ending in the letter Z,
as in
2023-06-03 12:00:01Z
This is treated as a datetime in the UTC time zone.
Simulate greedy parsing of an absolute datetime in the prefix of a string before parsing a subsequent time delta in the suffix of the string. This does not change the behavior of `parse_datetime`, it just prepares the code for a future change that allows parsing both the absolute datetime and the time delta from the same string. Greedy parsing is implemented by iterating over a list of patterns in decreasing order of length so that longer patterns are tried before shorter patterns. This guarantees that if there is an absolute datetime present at the beginning of the string, then it will definitely be parsed and the remaining part of the string is assumed to contain a time delta.
jfinkels
force-pushed
the
patterns-with-length
branch
from
dcba6af to
badc887
Compare
cakebaker
reviewed
Feb 11, 2025
Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #115 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simulate greedy parsing of an absolute datetime in the prefix of a
string before parsing a subsequent time delta in the suffix of the
string. This does not change the behavior of
parse_datetime, it justprepares the code for a future change that allows parsing both the
absolute datetime and the time delta from the same string.
Greedy parsing is implemented by iterating over a list of patterns in
decreasing order of length so that longer patterns are tried before
shorter patterns. This guarantees that if there is an absolute datetime
present at the beginning of the string, then it will definitely be
parsed and the remaining part of the string is assumed to contain a time
delta.
These changes were extracted from pull request #110.