Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-estree): use simpler absolutify behavior for project service client file paths #8520

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Feb 20, 2024

PR Checklist

Overview

Goes back to the absolutify function behavior that was removed in #7752 for massing the provided client file paths.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Feb 20, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 898b1df
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65d9edcc49654b0008384556
😎 Deploy Preview https://deploy-preview-8520--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 89 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 87.84%. Comparing base (c1441c8) to head (898b1df).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8520      +/-   ##
==========================================
+ Coverage   86.88%   87.84%   +0.95%     
==========================================
  Files         251      397     +146     
  Lines       12265    13844    +1579     
  Branches     3866     4073     +207     
==========================================
+ Hits        10657    12161    +1504     
- Misses       1338     1381      +43     
- Partials      270      302      +32     
Flag Coverage Δ
unittest 87.84% <91.66%> (+0.95%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...escript-estree/src/useProgramFromProjectService.ts 93.33% <91.66%> (+74.81%) ⬆️

... and 150 files with indirect coverage changes

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review February 21, 2024 01:50
@JoshuaKGoldberg JoshuaKGoldberg merged commit 5e7ec8f into typescript-eslint:main Feb 24, 2024
59 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the use-program-from-project-service-absolutify branch February 25, 2024 21:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Performance regression from #7752 in project service due to changed file name casing
2 participants