Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repo: Enable import/consistent-type-specifier-style internally #8523

Closed
JoshuaKGoldberg opened this issue Feb 21, 2024 · 0 comments · Fixed by #8527
Closed

Repo: Enable import/consistent-type-specifier-style internally #8523

JoshuaKGoldberg opened this issue Feb 21, 2024 · 0 comments · Fixed by #8527
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented Feb 21, 2024 •
edited

Suggestion

Splitting out from #8520 (comment): it'd be nice to standardize how we import with type specifiers. +1!

- import { type ASTAndDefiniteProgram } from './create-program/shared';
+ import type { ASTAndDefiniteProgram } from './create-program/shared';

Let's enable it with https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/consistent-type-specifier-style.md.
@JoshuaKGoldberg JoshuaKGoldberg added repo maintenance things to do with maintenance of the repo, and not with code/docs accepting prs Go ahead, send a pull request that resolves this issue labels Feb 21, 2024
@tarunrajput tarunrajput mentioned this issue Feb 21, 2024
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: enable import/consistent-type-specifier-style internally tarunrajput/typescript-eslint
1 participant
@JoshuaKGoldberg