Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript-estree): add debug logs for useProgramFromProjectService #8426

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Adds a few choice debug logs to useProgramFromProjectService.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Feb 10, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit c2cec0d
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65d4e79fd6c91c0008dfebef
😎 Deploy Preview https://deploy-preview-8426--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🟢 up 8 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Feb 10, 2024

Copy link

codecov bot commented Feb 10, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (f36f682) 86.94% compared to head (c2cec0d) 87.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8426      +/-   ##
==========================================
+ Coverage   86.94%   87.71%   +0.76%     
==========================================
  Files         252      398     +146     
  Lines       12251    13835    +1584     
  Branches     3861     4067     +206     
==========================================
+ Hits        10652    12135    +1483     
- Misses       1332     1403      +71     
- Partials      267      297      +30     
Flag Coverage Δ
unittest 87.71% <25.00%> (+0.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...escript-estree/src/useProgramFromProjectService.ts 18.51% <25.00%> (+2.72%) ⬆️

... and 146 files with indirect coverage changes

@JoshuaKGoldberg JoshuaKGoldberg merged commit 8431d9d into typescript-eslint:main Feb 23, 2024
62 of 64 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the use-program-from-project-service-logs branch February 23, 2024 12:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Add more debug logs to project service code paths
2 participants