Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(typescript-estree): disallow switch statements with multiple default cases #8411

Merged
merged 4 commits into from Mar 16, 2024
Merged

feat(typescript-estree): disallow switch statements with multiple default cases #8411

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
362dca8
feat: disallow switch statements with multiple default cases
DMartens Feb 8, 2024
185b04e
fix: add missing snapshots for new error fixture
DMartens Feb 8, 2024
10a7b46
Update fixture.ts to add a ending newline
bradzacher Mar 16, 2024
7dabbce
Update 1-TSESTree-Error.shot
bradzacher Mar 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...ast-spec/src/statement/SwitchStatement/fixtures/_error_/multiple-default-cases/fixture.ts
View file
Open in desktop
@@ -0,0 +1,3 @@
switch (true) {
default: default:
}
11 changes: 11 additions & 0 deletions ...t/SwitchStatement/fixtures/_error_/multiple-default-cases/snapshots/1-TSESTree-Error.shot
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions ...ment/SwitchStatement/fixtures/_error_/multiple-default-cases/snapshots/2-Babel-Error.shot
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions .../SwitchStatement/fixtures/_error_/multiple-default-cases/snapshots/3-Alignment-Error.shot
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 11 additions & 0 deletions packages/typescript-estree/src/convert.ts
View file
Open in desktop
Expand Up @@ -844,6 +844,17 @@
});

case SyntaxKind.SwitchStatement:
if (
node.caseBlock.clauses.filter(
switchCase => switchCase.kind === SyntaxKind.DefaultClause,

Check warning on line 849 in packages/typescript-estree/src/convert.ts

View check run for this annotation

Codecov / codecov/patch

packages/typescript-estree/src/convert.ts#L849 

Added line #L849 was not covered by tests
).length > 1
) {
this.#throwError(

Check warning on line 852 in packages/typescript-estree/src/convert.ts

View check run for this annotation

Codecov / codecov/patch

packages/typescript-estree/src/convert.ts#L852 

Added line #L852 was not covered by tests
node,
"A 'default' clause cannot appear more than once in a 'switch' statement.",
);
}

return this.createNode<TSESTree.SwitchStatement>(node, {
type: AST_NODE_TYPES.SwitchStatement,
discriminant: this.convertChild(node.expression),
Expand Down