New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(typescript-estree): disallow switch statements with multiple default cases #8411
feat(typescript-estree): disallow switch statements with multiple default cases #8411
Conversation
Thanks for the PR, @DMartens! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8411 +/- ##
==========================================
+ Coverage 86.94% 87.72% +0.78%
==========================================
Files 252 398 +146
Lines 12251 13830 +1579
Branches 3861 4068 +207
==========================================
+ Hits 10652 12133 +1481
- Misses 1332 1400 +68
- Partials 267 297 +30
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Will add 1 approval
and leave open for a bit in case @bradzacher wants to review too, since Brad also commented on the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Checklist
Overview
Throw an error if a switch statement has multiple default cases with the same message as the TypeScript diagnostics.