feat(eslint-plugin): [restrict-template-expressions] add allowArray option

[abrahamguo]

PR Checklist

• Addresses an existing open issue: begins to fix Enhancement: [restrict-template-expressions] More permissive type check #6279
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

I've added a new allowArray option that applies the existing checks from restrict-template-expressions recursively (i.e. no undefineds, etc.).

I haven't added unit tests yet but I'd like to begin receiving feedback on this change.

[typescript-eslint]

Thanks for the PR, @abrahamguo!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	9a3c36a
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/65eef16041aa3f0008d14d3d
😎 Deploy Preview	https://deploy-preview-8389--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 94 (🟢 up 4 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9a3c36a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 31 targets

• nx test eslint-plugin
• nx test eslint-plugin --coverage=false
• nx test utils
• nx test typescript-eslint
• nx run types:build
• nx test repo-tools
• nx test typescript-estree
• nx test rule-schema-to-typescript-types
• nx test scope-manager
• nx test type-utils
• nx run repo-tools:postinstall-script
• nx test visitor-keys
• nx test ast-spec
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint
• nx test parser
• nx run-many --target=lint --parallel --exclude eslint-plugin
• nx test eslint-plugin-internal
• nx test visitor-keys --coverage=false
• nx run-many --target=typecheck --parallel
• nx test rule-schema-to-typescript-types --coverage=false
• nx test scope-manager --coverage=false
• nx test utils --coverage=false
• nx test typescript-estree --coverage=false
• nx run repo-tools:generate-configs
• nx test parser --coverage=false
• nx test eslint-plugin-internal --coverage=false
• nx test type-utils --coverage=false
• nx test repo-tools --coverage=false
• nx test typescript-eslint --coverage=false
• nx test ast-spec --coverage=false
• nx run integration-tests:test

---

Sent with 💌 from NxCloud.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.20%. Comparing base (c0e3267) to head (9a3c36a).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8389      +/-   ##
==========================================
- Coverage   87.21%   87.20%   -0.01%     
==========================================
  Files         251      251              
  Lines       12315    12308       -7     
  Branches     3883     3875       -8     
==========================================
- Hits        10740    10733       -7     
  Misses       1305     1305              
  Partials      270      270              

Flag	Coverage Δ
unittest	87.20% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...-plugin/src/rules/restrict-template-expressions.ts	100.00% <100.00%> (ø)

[JoshuaKGoldberg]

This is a clever way of automating the repeated parts 🙂. Nicely done.

...but like many clever code things, there was a difficulty cost of reading it at first. I played around with it locally and found it easier to read through with a few small structural changes. What do you think?

[JoshuaKGoldberg]

Super, looks good to me! Thanks for all the code tinkering. 😄

Leaving open with 1 approval as I know at least @bradzacher has had well-informed thoughts on this family of rules in the past.

[bradzacher]

[bradzacher]

@JoshuaKGoldberg - Originally this rule's purpose was to prevent code like node.type === 'string'.
Given we now have the no-unsafe-enum-comparison rule - do you think this internal rule still has value? WDYT about deleting it? (we already have nuec turned on via the recommended config)

[JoshuaKGoldberg]

Yeah I'd be in favor of that. It wouldn't be the first example of an internal lint rule ending up as a subset of a general good one.