Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ignoredTypeNames option for restrict-template-expressions #8556

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

abrahamguo
Copy link
Contributor

PR Checklist

Overview

Building on the work from #8389, which @JoshuaKGoldberg has been reviewing, this PR ports the ignoredTypeNames option from no-base-to-string into restrict-template-expressions. I'm open to further discussion about this, as this update definitely blurs the line between the two rules.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @abrahamguo!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Feb 27, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit f5396c6
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65f5a3a51a7496000895e4f7
😎 Deploy Preview https://deploy-preview-8556--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 87 (🔴 down 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@JoshuaKGoldberg JoshuaKGoldberg requested review from bradzacher and removed request for bradzacher March 18, 2024 12:56
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this in - but would you be open to filing an issue? I think we'd want to discuss this a bit before landing it.

Also, just a couple preliminary review thoughts if it does land:

  • Unit tests?
  • I think we'd want to share the default value of ignoredTypeNames in a constant so it doesn't risk getting out of sync

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Mar 18, 2024
@JoshuaKGoldberg
Copy link
Member

Marking as a draft pending #8722's resolution.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as draft April 23, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting response Issues waiting for a reply from the OP or another party
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: [restrict-template-expressions] More permissive type check
2 participants