Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin): [naming-convention] support the auto-accessor syntax #8084
feat(eslint-plugin): [naming-convention] support the auto-accessor syntax #8084
Changes from 25 commits
1662bd3
25feaba
2d47b74
c1b1796
1fe2d01
2bb04b7
4636e6d
0149a62
2351b09
45a5118
320320e
c08c4cf
3762356
c4ae266
ec931d8
9a42efe
47fd96a
3d05845
bd7947a
9148131
d8114e8
468549d
9fbc50c
e6a1d27
813b1ec
11d81c1
16eb834
88acaae
eb935d0
8f1c37d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Testing] It's good to have created a test file for
classicAccessor
- but there should also be a test case file foraccessor
too! (so, three*.test.ts
files around accessors, not two)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes! Added here
88acaae
. There are a bunch of tests in the other file tootypescript-eslint/packages/eslint-plugin/tests/rules/naming-convention/naming-convention.test.ts
Lines 610 to 625 in 1200b4c