feat(eslint-plugin): [naming-convention] support the auto-accessor syntax

[arka1002]

Fixes: #7823

PR Checklist

• Addresses an existing open issue: fixes [naming-convention] support the auto-accessor syntax #7823
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

Adds auto-accessor in the accessor selector.

[typescript-eslint]

Thanks for the PR, @arka1002!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	8f1c37d
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/65d7c4a4e20ade0008e8d990
😎 Deploy Preview	https://deploy-preview-8084--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (🟢 up 9 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[arka1002]

@Josh-Cena can you please take a look.

[JoshuaKGoldberg]

Functionally looks great, thanks! Nice and straightforward. 🙂

Just requesting changes to get it documented too. Every selector option should be.

Btw, no need to ping individuals for review. We have a queue and we get to things when we can.

[JoshuaKGoldberg]

Progress, thanks for working on it!

I'll defer to @bradzacher for final approval - but I think having more docs and matching test coverage to the new feature would be good.

[JoshuaKGoldberg]

Adding back awaiting response as we haven't been explicitly re-requested for review. But if if / when this is ready, happy to take another look!

[arka1002]

@JoshuaKGoldberg I don't have the button to re-request review :(

From my side, changes are done, this might be worth a discussion - #8084 (comment) - wdyt ?

[JoshuaKGoldberg]

I think the direction is good - but the two new sub-groups shouldn't have overlapping matches, no?

[JoshuaKGoldberg]

[Testing] It's good to have created a test file for classicAccessor - but there should also be a test case file for accessor too! (so, three *.test.ts files around accessors, not two)

[arka1002]

Ah yes! Added here 88acaae. There are a bunch of tests in the other file too

typescript-eslint/packages/eslint-plugin/tests/rules/naming-convention/naming-convention.test.ts

Lines 610 to 625 in 1200b4c

	class Ignored {
	private static get some_name() {}
	get IgnoredDueToModifiers() {}
	}
	`,
	options: [
	{
	selector: 'default',
	format: ['PascalCase'],
	},
	{
	selector: 'accessor',
	format: ['snake_case'],
	modifiers: ['private', 'static'],
	},
	],

[JoshuaKGoldberg]

I don't have the button to re-request review :(

Oh, I think I got lost in the GitHub UI - I see you did re-request review from at least me. Sorry about that!

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8f1c37d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 31 targets

• nx test eslint-plugin
• nx test eslint-plugin --coverage=false
• nx test utils
• nx run types:build
• nx test typescript-estree
• nx test repo-tools
• nx test typescript-eslint
• nx test visitor-keys
• nx run repo-tools:postinstall-script
• nx test parser
• nx test type-utils
• nx test scope-manager
• nx test rule-schema-to-typescript-types
• nx test ast-spec
• nx run-many --target=lint --parallel
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint
• nx test eslint-plugin-internal
• nx run-many --target=typecheck --parallel
• nx test utils --coverage=false
• nx test type-utils --coverage=false
• nx test scope-manager --coverage=false
• nx test visitor-keys --coverage=false
• nx test typescript-eslint --coverage=false
• nx test typescript-estree --coverage=false
• nx test rule-schema-to-typescript-types --coverage=false
• nx test parser --coverage=false
• nx test ast-spec --coverage=false
• nx run integration-tests:test
• nx test repo-tools --coverage=false
• nx test eslint-plugin-internal --coverage=false
• nx run repo-tools:generate-configs

---

Sent with 💌 from NxCloud.

[JoshuaKGoldberg]

Whoohoo, this is lovely! 🙌

Thanks for working on it & iterating with us @arka1002. Really nicely done final result here.

I just have the one docs request, but nothing left from me in code. Will defer to @bradzacher. 🙂

[bradzacher]

one small change otherwise LGTM
thanks so much for working on this!