Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(website): [playground] option to disable scroll and display tokens #6863

Merged
merged 5 commits into from
Apr 16, 2023

Conversation

armano2
Copy link
Member

@armano2 armano2 commented Apr 7, 2023

PR Checklist

Overview

  • always display comments in ast
  • allow to display tokens by enabling flag
  • allow to disable scrolling -> this is useful for mobile devices

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Apr 7, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 946fa3d
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/643c37c4dbe526000828f680
😎 Deploy Preview https://deploy-preview-6863--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nx-cloud
Copy link

nx-cloud bot commented Apr 7, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 946fa3d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 30 targets

Sent with 💌 from NxCloud.

@armano2 armano2 changed the title chore(website): [playground] add ability to disable scrolling and sho… chore(website): [playground] option to disable scroll and display tokens Apr 7, 2023
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 this is great, thanks! I've always found tokens to be irksome to work with without playground viewing support.

packages/website/src/components/ast/utils.ts Outdated Show resolved Hide resolved
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
@codecov
Copy link

codecov bot commented Apr 16, 2023

Codecov Report

Merging #6863 (946fa3d) into v6 (a35a2bb) will increase coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##               v6    #6863      +/-   ##
==========================================
+ Coverage   87.46%   87.50%   +0.03%     
==========================================
  Files         374      376       +2     
  Lines       12879    12934      +55     
  Branches     3811     3820       +9     
==========================================
+ Hits        11265    11318      +53     
- Misses       1229     1231       +2     
  Partials      385      385              
Flag Coverage Δ
unittest 87.50% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

@armano2 armano2 merged commit bffdb62 into v6 Apr 16, 2023
42 checks passed
@armano2 armano2 deleted the chore/playground-disable-scrolling-and-show-tokens branch April 16, 2023 18:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants