feat(typescript-estree): throw errors when abstract property has initializer

[fisker]

PR Checklist

• Addresses an existing open issue: fixes #000
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

[typescript-eslint]

Thanks for the PR, @fisker!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f95b84c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

🟥 Failed Commands
Node 14 - nx test eslint-plugin --coverage=false

✅ Successfully ran 49 targets

• Node 18 - nx test utils
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx test typescript-estree
• Node 18 - nx test parser
• Node 18 - nx test scope-manager
• Node 18 - nx test type-utils
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx test visitor-keys
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx test repo-tools
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx test eslint-plugin-tslint
• Node 18 - nx test eslint-plugin-internal
• Node 18 - nx test ast-spec
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx run-many --target=build --parallel --exclude website
• nx run-many --target=lint --parallel
• Node 14 - nx test typescript-estree --coverage=false
• Node 14 - nx test type-utils --coverage=false
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx test visitor-keys --coverage=false
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx test scope-manager --coverage=false
• Node 14 - nx test parser --coverage=false
• Node 14 - nx test utils --coverage=false
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx test repo-tools --coverage=false
• Node 14 - nx run-many --target=build --parallel --exclude website
• nx run-many --target=typecheck --parallel
• Node 14 - nx test eslint-plugin-tslint --coverage=false
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx test eslint-plugin-internal --coverage=false
• Node 14 - nx run-many --target=build --parallel --exclude website
• nx run integration-tests:test
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx test ast-spec --coverage=false
• nx run-many --target=build --parallel --exclude website
• Node 14 - nx run-many --target=build --parallel --exclude website
• nx run-many --target=build --parallel --exclude website
• nx run-many --target=build --parallel --exclude website
• nx run-many --target=build --parallel --exclude website

---

Sent with 💌 from NxCloud.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	3d509cf
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/64125cff7757750008e4f65c
😎 Deploy Preview	https://deploy-preview-6613--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[JoshuaKGoldberg]

🔥 love to see it, thanks as always!

[bradzacher]

need to fix up this case:

typescript-eslint/packages/eslint-plugin/tests/rules/naming-convention/cases/property.test.ts

Line 11 in 2b2a075

'class Ignored { abstract % = 1 }',

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3d509cf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 30 targets

• Node 14 - nx test eslint-plugin --coverage=false
• Node 18 - nx test eslint-plugin
• nx run-many --target=build --projects=website-eslint,website
• nx run-many --target=lint --parallel
• Node 18 - nx test scope-manager
• Node 18 - nx test typescript-estree
• Node 18 - nx test utils
• Node 18 - nx run types:build
• Node 18 - nx test visitor-keys
• Node 18 - nx test type-utils
• nx run-many --target=typecheck --parallel
• Node 18 - nx test parser
• Node 18 - nx test repo-tools
• Node 18 - nx test eslint-plugin-tslint
• Node 18 - nx test eslint-plugin-internal
• Node 14 - nx test typescript-estree --coverage=false
• nx run integration-tests:test
• Node 14 - nx test type-utils --coverage=false
• Node 14 - nx run types:build
• Node 18 - nx test ast-spec
• Node 14 - nx test scope-manager --coverage=false
• nx run types:build
• Node 14 - nx test visitor-keys --coverage=false
• Node 14 - nx test parser --coverage=false
• Node 14 - nx test eslint-plugin-internal --coverage=false
• Node 14 - nx test ast-spec --coverage=false
• Node 14 - nx test utils --coverage=false
• Node 14 - nx test repo-tools --coverage=false
• Node 14 - nx test eslint-plugin-tslint --coverage=false
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint

---

Sent with 💌 from NxCloud.

[codecov]

Codecov Report

Merging #6613 (3d509cf) into v6 (62d6230) will decrease coverage by 0.02%.
The diff coverage is 33.33%.

Additional details and impacted files

@@            Coverage Diff             @@
##               v6    #6613      +/-   ##
==========================================
- Coverage   85.25%   85.23%   -0.02%     
==========================================
  Files         372      372              
  Lines       12727    12729       +2     
  Branches     3782     3783       +1     
==========================================
  Hits        10850    10850              
- Misses       1498     1499       +1     
- Partials      379      380       +1     

Flag	Coverage Δ
unittest	85.23% <33.33%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/typescript-estree/src/convert.ts	31.03% <33.33%> (-0.09%)	⬇️