Skip to content

Commit

Permalink
chore: bump allowed version ranges to include TS 5.0 (#6612)
Browse files Browse the repository at this point in the history
  • Loading branch information
bradzacher committed Mar 13, 2023
1 parent 9d3bdfc commit 2b2a075
Show file tree
Hide file tree
Showing 2,213 changed files with 8,249 additions and 10,310 deletions.
90 changes: 46 additions & 44 deletions .github/workflows/ci.yml
Expand Up @@ -176,50 +176,52 @@ jobs:
# Sadly 1 day is the minimum
retention-days: 1

website_tests:
permissions:
contents: read # to fetch code (actions/checkout)

name: Website tests
# We technically do not need to wait for build within the pipeline any more because the build we care about is happening within Netlify, however,
# it is highly likely that if the CI one fails, the Netlify one will as well, so in order to not waste unncessary Github Actions minutes/resources,
# we do still keep this requirement here.
needs: [build]
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
with:
fetch-depth: 2

- name: Install
uses: ./.github/actions/prepare-install
with:
node-version: ${{ env.PRIMARY_NODE_VERSION }}

- name: Install Playwright Browsers
run: npx playwright install --with-deps

- name: Wait for Netlify deployment
uses: probablyup/wait-for-netlify-action@v3.4.0
id: waitForDeployment
with:
site_id: '128d21c7-b2fe-45ad-b141-9878fcf5de3a'
max_timeout: 300 # 5 minutes
env:
NETLIFY_TOKEN: ${{ secrets.NETLIFY_TOKEN }}

- name: Run Playwright tests against the Netlify deployment
run: yarn playwright test --reporter=list
working-directory: packages/website
env:
PLAYWRIGHT_TEST_BASE_URL: ${{ steps.waitForDeployment.outputs.url }}

- if: always()
uses: actions/upload-artifact@v3
with:
name: playwright-report
path: packages/website/playwright-report
## TODO - re-enable once we fix them
# https://github.com/typescript-eslint/typescript-eslint/issues/6508
# website_tests:
# permissions:
# contents: read # to fetch code (actions/checkout)

# name: Website tests
# # We technically do not need to wait for build within the pipeline any more because the build we care about is happening within Netlify, however,
# # it is highly likely that if the CI one fails, the Netlify one will as well, so in order to not waste unncessary Github Actions minutes/resources,
# # we do still keep this requirement here.
# needs: [build]
# runs-on: ubuntu-latest
# steps:
# - name: Checkout
# uses: actions/checkout@v3
# with:
# fetch-depth: 2

# - name: Install
# uses: ./.github/actions/prepare-install
# with:
# node-version: ${{ env.PRIMARY_NODE_VERSION }}

# - name: Install Playwright Browsers
# run: npx playwright install --with-deps

# - name: Wait for Netlify deployment
# uses: probablyup/wait-for-netlify-action@v3.4.0
# id: waitForDeployment
# with:
# site_id: '128d21c7-b2fe-45ad-b141-9878fcf5de3a'
# max_timeout: 300 # 5 minutes
# env:
# NETLIFY_TOKEN: ${{ secrets.NETLIFY_TOKEN }}

# - name: Run Playwright tests against the Netlify deployment
# run: yarn playwright test --reporter=list
# working-directory: packages/website
# env:
# PLAYWRIGHT_TEST_BASE_URL: ${{ steps.waitForDeployment.outputs.url }}

# - if: always()
# uses: actions/upload-artifact@v3
# with:
# name: playwright-report
# path: packages/website/playwright-report

upload_coverage:
name: Upload Codecov Coverage
Expand Down
2 changes: 1 addition & 1 deletion docs/maintenance/Versioning.mdx
Expand Up @@ -52,7 +52,7 @@ Support for specific Current status releases are considered periodically.

### TypeScript

> The version range of TypeScript currently supported is `>=3.3.1 <5.0.0`.
> The version range of TypeScript currently supported is `>=3.3.1 <5.1.0`.
These versions are what we test against.

Expand Down
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -108,7 +108,7 @@
"ts-node": "10.7.0",
"tslint": "^6.1.3",
"tsx": "^3.12.1",
"typescript": ">=3.3.1 <4.9.5 || 5.0.1-rc"
"typescript": ">=3.3.1 <5.1.0 || 5.0.1-rc"
},
"resolutions": {
"typescript": "~5.0.1-rc",
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 2b2a075

Please sign in to comment.