fix: rename typeParameters to typeArguments where needed

[JoshuaKGoldberg]

BREAKING CHANGE:
Adds duplicate properties on the AST and deprecates their old names

PR Checklist

• Addresses an existing open issue: fixes Some properties named typeParameters instead of typeArguments #146
• That issue was marked as accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

Renames typeParameters to typeArguments in locations that are indeed providing type arguments.

To recap the terminology:

• An argument is something you provide to a recipient, such as a type provided explicitly to a call expression
• A parameter is how the recipient receives what you provide, such as a function declaration's generic type parameter

Marked as a breaking change even though the old, now-@deprecated property is still there.

[typescript-eslint]

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 627a883. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

🟥 Failed Commands
nx run-many --target=lint --parallel

✅ Successfully ran 50 targets

• Node 18 - nx test eslint-plugin
• Node 14 - nx test eslint-plugin --coverage=false
• Node 18 - nx test typescript-estree
• Node 18 - nx test scope-manager
• Node 18 - nx test visitor-keys
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx test type-utils
• Node 18 - nx test utils
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx run-many --target=build --parallel --exclude website
• nx run integration-tests:test
• Node 14 - nx test typescript-estree --coverage=false
• Node 14 - nx test scope-manager --coverage=false
• Node 14 - nx test parser --coverage=false
• Node 18 - nx test eslint-plugin-internal
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx run-many --target=build --parallel --exclude website
• nx run-many --target=build --parallel --exclude website
• nx run-many --target=typecheck --parallel
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx test type-utils --coverage=false
• Node 14 - nx test utils --coverage=false
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx test eslint-plugin-tslint --coverage=false
• Node 14 - nx test eslint-plugin-internal --coverage=false
• Node 14 - nx test visitor-keys --coverage=false
• Node 14 - nx test ast-spec --coverage=false
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx test eslint-plugin-tslint
• Node 14 - nx test repo-tools --coverage=false
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx test parser
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx test ast-spec
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx test repo-tools
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx run-many --target=build --parallel --exclude website
• nx run-many --target=build --parallel --exclude website
• Node 18 - nx run-many --target=build --parallel --exclude website
• nx run-many --target=build --parallel --exclude website
• nx run-many --target=build --parallel --exclude website

---

Sent with 💌 from NxCloud.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	627a883
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/63f7061a0a1f550008a8517d
😎 Deploy Preview	https://deploy-preview-5384--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[bradzacher]

Thinking about this in terms of the broader ecosystem and the impacts - I wonder if we want to give consumers one major version to migrate?
A hard cut over might be a bit difficult for the ecosystem to come handle as it would involve every single plugin updating their code (which could leave users in an impossible to upgrade state for some time).

How about this: this version we add the new property and we mark the old property as @deprecated, then in v7 we remove the old property entirely.

If we wanted we could also do something like define a getter that throws when in a test environment to help flag plugins that they should migrate.

WDYT?

[JoshuaKGoldberg]

Yeah that makes sense. I'll put the @deprecated old properties in this PR (once I get the new ones working)

The process env check + getter idea is really nifty - seems like a good followup feature request. I'd like to get it in v6... thinking 🤔

[codecov]

Codecov Report

Merging #5384 (627a883) into v6 (d676683) will not change coverage.
The diff coverage is 72.50%.

Additional details and impacted files

@@           Coverage Diff           @@
##               v6    #5384   +/-   ##
=======================================
  Coverage   87.06%   87.06%           
=======================================
  Files         365      365           
  Lines       12579    12579           
  Branches     3720     3720           
=======================================
  Hits        10952    10952           
  Misses       1278     1278           
  Partials      349      349           

Flag	Coverage Δ
unittest	87.06% <72.50%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...es/eslint-plugin/src/rules/no-array-constructor.ts	100.00% <ø> (ø)
...es/eslint-plugin/src/rules/no-invalid-void-type.ts	95.83% <0.00%> (ø)
packages/eslint-plugin/src/rules/no-type-alias.ts	100.00% <ø> (ø)
packages/type-utils/src/isUnsafeAssignment.ts	84.00% <ø> (ø)
packages/visitor-keys/src/visitor-keys.ts	100.00% <ø> (ø)
packages/typescript-estree/src/convert.ts	28.20% <18.18%> (ø)
packages/eslint-plugin/src/rules/array-type.ts	97.14% <100.00%> (ø)
packages/eslint-plugin/src/rules/ban-types.ts	100.00% <100.00%> (ø)
...lugin/src/rules/consistent-generic-constructors.ts	90.69% <100.00%> (ø)
...lugin/src/rules/consistent-indexed-object-style.ts	92.06% <100.00%> (ø)
... and 9 more

[bradzacher]

Yeah that makes sense. I'll put the @deprecated old properties in this PR (once I get the new ones working)

Once we've got this change, this is good-to-go I think.

[JoshuaKGoldberg]

I think the lint & integration test failures are unrelated to this PR. Indeed, they were ✅