Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin): [prefer-readonly-parameter-types] added an optional type allowlist #4436
feat(eslint-plugin): [prefer-readonly-parameter-types] added an optional type allowlist #4436
Changes from 62 commits
453ac54
e0a04d7
06a0631
618fbd1
17d013e
6fd713d
b8cdd5c
4ab1f5f
49713c8
6d842ec
2734b7a
d4fa56b
3df00ed
8188084
53aac78
efd4140
0504608
7a6c943
f2acfaa
b178a21
e8af7cb
5e18240
59371e7
3eb89b6
766a2e7
854dcac
0e489cb
6534ef3
5474d23
81b18e3
164ae2b
6bda8a3
abfc236
ff28c54
da498ea
bd6b77d
bbca206
eec8883
ffd2aae
611ca15
c4d0a3f
5d74151
fb67f4d
c4334cc
bc3ce11
1e1bfc2
c5c1d70
22bb891
af5cfc0
5c3f37f
60dcf36
e6d81a9
2d242f0
333d008
08eebc8
eb7aef6
b5b91cb
e41d8be
852ca69
5407105
b9f785c
8626d16
235acd3
a1f38dd
93fbcd8
3ad0e9e
0bd7601
0136e5b
386fd03
ed1e07a
3a89ec5
346fdbc
609351e
a535fb6
8e3f910
95bbaa5
5eae317
751e2de
3d465cc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
defaultLib
would be a betterfrom
value as it would make it more explicit that it refers to the TypeScript default libs rather than just a random lib.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #5271 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, that's were all the conversation about the details is. 🙂