Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eslint-plugin): [prefer-readonly-parameter-types] added an optional type allowlist #4436

Merged
merged 79 commits into from Mar 20, 2023
Merged

feat(eslint-plugin): [prefer-readonly-parameter-types] added an optional type allowlist #4436

merged 79 commits into from Mar 20, 2023

Commits on Jan 12, 2022

  1. feat(eslint-plugin): [prefer-readonly-parameter-types] Added an optio… 

    …nal type whitelist
    @marekdedic
    marekdedic committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    453ac54 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2022

  1. chore(eslint-plugin): [prefer-readonly-parameter-types] whitelist -> … 

    …allowlist
    @marekdedic
    marekdedic committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    e0a04d7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into prefer-readonly-parameter-types-whitelist

    @marekdedic
    marekdedic committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    06a0631 View commit details
    Browse the repository at this point in the history

  3. feat(eslint-plugin): [prefer-readonly-parameter-types] Split the allo… 

    …wlist between internal and configurable
    @marekdedic
    marekdedic committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    618fbd1 View commit details
    Browse the repository at this point in the history

  4. fix(eslint-plugin): [prefer-readonly-parameter-types] Fixed lint issu… 

    …e with non-null assertion
    @marekdedic
    marekdedic committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    17d013e View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2022

  1. fix(eslint-plugin): [prefer-readonly-parameter-types] Using allowlist… 

    … everywhere in deep readonlyness checks
    @marekdedic
    marekdedic committed Jan 15, 2022
    Configuration menu
    Copy the full SHA
    6fd713d View commit details
    Browse the repository at this point in the history

  2. fix(eslint-plugin): [prefer-readonly-parameter-types] Passing interna… 

    …l allowlist from rule
    @marekdedic
    marekdedic committed Jan 15, 2022
    Configuration menu
    Copy the full SHA
    b8cdd5c View commit details
    Browse the repository at this point in the history

  3. fix(eslint-plugin): [prefer-readonly-parameter-types] Decoupled optio… 

    …ns and schema of rule and util
    @marekdedic
    marekdedic committed Jan 15, 2022
    Configuration menu
    Copy the full SHA
    4ab1f5f View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2022

  1. feat(eslint-plugin): [prefer-readonly-parameter-types] Added tests

    @marekdedic
    marekdedic committed Jan 16, 2022
    Configuration menu
    Copy the full SHA
    49713c8 View commit details
    Browse the repository at this point in the history

  2. fix(eslint-plugin): [prefer-readonly-parameter-types] Added missing d… 

    …ocs for option treatMethodsAsReadonly
    @marekdedic
    marekdedic committed Jan 16, 2022
    Configuration menu
    Copy the full SHA
    6d842ec View commit details
    Browse the repository at this point in the history

  3. docs(eslint-plugin): [prefer-readonly-parameter-types] Added docs for… 

    … allowlist
    @marekdedic
    marekdedic committed Jan 16, 2022
    Configuration menu
    Copy the full SHA
    2734b7a View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2022

  1. Merge branch 'main' into prefer-readonly-parameter-types-whitelist

    @marekdedic
    marekdedic committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    d4fa56b View commit details
    Browse the repository at this point in the history

  2. fix(eslint-plugin): [prefer-readonly-parameter-types] Fixed regressio… 

    …ns from merging main
    @marekdedic
    marekdedic committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    3df00ed View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2022

  1. Merge branch 'main' into prefer-readonly-parameter-types-whitelist

    @marekdedic
    marekdedic committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    8188084 View commit details
    Browse the repository at this point in the history

  2. feat(eslint-plugin): [prefer-readonly-parameter-types] Merged excepti… 

    …ons and internalExceptions together to create a universal allowlist API
    @marekdedic
    marekdedic committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    53aac78 View commit details
    Browse the repository at this point in the history

  3. feat(eslint-plugin): [prefer-readonly-parameter-types] Added a schema… 

    … for type allowlist
    @marekdedic
    marekdedic committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    efd4140 View commit details
    Browse the repository at this point in the history

  4. chore(eslint-plugin): [prefer-readonly-parameter-types] Split TypeAll… 

    …owlistItem out into own file
    @marekdedic
    marekdedic committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    0504608 View commit details
    Browse the repository at this point in the history

  5. docs(eslint-plugin): [prefer-readonly-parameter-types] Updated docs f… 

    …or the more sophisticated allowlist
    @marekdedic
    marekdedic committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    7a6c943 View commit details
    Browse the repository at this point in the history

  6. docs(eslint-plugin): [prefer-readonly-parameter-types] Fixed allowlis… 

    …t option type
    @marekdedic
    marekdedic committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    f2acfaa View commit details
    Browse the repository at this point in the history

  7. test(eslint-plugin): [prefer-readonly-parameter-types] Added tests fo… 

    …r type allowlist with wrong kinds of types
    @marekdedic
    marekdedic committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    b178a21 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2022

  1. chore(eslint-plugin): [prefer-readonly-parameter-types] Deduplicated … 

    …default configuration
    @marekdedic
    marekdedic committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    e8af7cb View commit details
    Browse the repository at this point in the history

  2. fix(eslint-plugin): [prefer-readonly-parameter-types] Added back read… 

    …onlynessOptionsSchema
    @marekdedic
    marekdedic committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    5e18240 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2022

  1. chore(eslint-plugin): [prefer-readonly-parameter-types] Removed defau… 

    …lt allowlist
    @marekdedic
    marekdedic committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    59371e7 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2022

  1. docs(eslint-plugin): [prefer-readonly-parameter-types] Fixed default … 

    …allowlist in docs
    @marekdedic
    marekdedic committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    3eb89b6 View commit details
    Browse the repository at this point in the history

  2. test(eslint-plugin): [prefer-readonly-parameter-types] Not using DOM … 

    …in tests
    @marekdedic
    marekdedic committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    766a2e7 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2022

  1. chore(eslint-plugin): [prefer-readonly-parameter-types] Using propert… 

    …y shorthand
    @marekdedic
    marekdedic committed Jan 29, 2022
    Configuration menu
    Copy the full SHA
    854dcac View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2022

  1. feat(eslint-plugin): [prefer-readonly-parameter-types] TypeAllowlistI… 

    …tem is now a discriminated union
    @marekdedic
    marekdedic committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    0e489cb View commit details
    Browse the repository at this point in the history

  2. docs(eslint-plugin): [prefer-readonly-parameter-types] TypeAllowlistI… 

    …tem is now a discriminated union - docs update
    @marekdedic
    marekdedic committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    6534ef3 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2022

  1. Merge branch 'main' into prefer-readonly-parameter-types-whitelist

    @marekdedic
    marekdedic committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    5474d23 View commit details
    Browse the repository at this point in the history

  2. test(type-utils): [prefer-readonly-parameter-types] Added rudimentary… 

    … test for allowlist
    @marekdedic
    marekdedic committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    81b18e3 View commit details
    Browse the repository at this point in the history

  3. test(type-utils): [prefer-readonly-parameter-types] Added test for al… 

    …lowlist containing local definition
    @marekdedic
    marekdedic committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    164ae2b View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2022

  1. Update packages/type-utils/src/TypeAllowListItem.ts to use enum in JS… 

    …ON schema

Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
    @marekdedic @bradzacher
    marekdedic and bradzacher committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    6bda8a3 View commit details
    Browse the repository at this point in the history

  2. fix(eslint-plugin): [prefer-readonly-parameter-types] Added trainling… 

    … slash to package path check
    @marekdedic
    marekdedic committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    abfc236 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2022

  1. Merge branch 'main' into prefer-readonly-parameter-types-whitelist

    @marekdedic
    marekdedic committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    ff28c54 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2022

  1. Merge branch 'main' into prefer-readonly-parameter-types-whitelist

    @bradzacher
    bradzacher committed May 18, 2022
    Configuration menu
    Copy the full SHA
    da498ea View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2022

  1. Merge branch 'main' into prefer-readonly-parameter-types-whitelist

    @marekdedic
    marekdedic committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    bd6b77d View commit details
    Browse the repository at this point in the history

  2. fix(eslint-plugin) Fixed type imports not being separated

    @marekdedic
    marekdedic committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    bbca206 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2023

  1. Merge branch 'main' into prefer-readonly-parameter-types-whitelist

    @marekdedic
    marekdedic committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    eec8883 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2023

  1. feat(type-utils): Added TypeOrValueSpecifier, its schema and test for… 

    … the schema
    @marekdedic
    marekdedic committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    ffd2aae View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into prefer-readonly-parameter-types-whitelist

    @marekdedic
    marekdedic committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    611ca15 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2023

  1. feat(type-utils): Added typeMatchesSpecifier() and switched isTypeRea… 

    …donly over to TypeOrValueSpecifier
    @marekdedic
    marekdedic committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    c4d0a3f View commit details
    Browse the repository at this point in the history

  2. fix(eslint-plugin): [prefer-readonly-parameter-types] Fixed tests hav… 

    …ing old allowlist format
    @marekdedic
    marekdedic committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    5d74151 View commit details
    Browse the repository at this point in the history

  3. fix(type-utils): Removed unneeded function isTypeExcepted

    @marekdedic
    marekdedic committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    fb67f4d View commit details
    Browse the repository at this point in the history

  4. feat(type-utils): Added source file checking to typeMatchesFileSpecif… 

    …ier()
    @marekdedic
    marekdedic committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    c4334cc View commit details
    Browse the repository at this point in the history

  5. docs(eslint-plugin): [prefer-readonly-parameter-types] Updated docs t… 

    …o use TypeOrValueSpecifier allowlist style
    @marekdedic
    marekdedic committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    bc3ce11 View commit details
    Browse the repository at this point in the history

  6. docs(eslint-plugin): [prefer-readonly-parameter-types] Typo fix

    @marekdedic
    marekdedic committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    1e1bfc2 View commit details
    Browse the repository at this point in the history

  7. docs(eslint-plugin): [prefer-readonly-parameter-types] Typo fix 2

    @marekdedic
    marekdedic committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    c5c1d70 View commit details
    Browse the repository at this point in the history

  8. feat(type-utils): Added tests for typeMatchesSpecifier()

    @marekdedic
    marekdedic committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    22bb891 View commit details
    Browse the repository at this point in the history

  9. fix(type-utils): Using node path joining typeMatchesSpecifier()

    @marekdedic
    marekdedic committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    af5cfc0 View commit details
    Browse the repository at this point in the history

  10. feat(type-utils): Removed MultiSourceSpecifier

    @marekdedic
    marekdedic committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    5c3f37f View commit details
    Browse the repository at this point in the history

  11. chore(type-utils): Simplified typeMatchesSpecifier()

    @marekdedic
    marekdedic committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    60dcf36 View commit details
    Browse the repository at this point in the history

  12. feat(type-utils): Added more tests for typeMatchesSpecifier()

    @marekdedic
    marekdedic committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    e6d81a9 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2023

  1. Merge branch 'v6' into prefer-readonly-parameter-types-whitelist

    @marekdedic
    marekdedic committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    2d242f0 View commit details
    Browse the repository at this point in the history

  2. docs(prefer-readonly-parameter-types) more legible docs 

    Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
    @marekdedic @JoshuaKGoldberg
    marekdedic and JoshuaKGoldberg committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    333d008 View commit details
    Browse the repository at this point in the history

  3. fix(eslint-plugin): [prefer-readonly-parameter-types] Fixed missing e… 

    …nd of code listing in docs
    @marekdedic
    marekdedic committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    08eebc8 View commit details
    Browse the repository at this point in the history

  4. chore(type-utils): Simplified typeDeclaredInFile()

    @marekdedic
    marekdedic committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    eb7aef6 View commit details
    Browse the repository at this point in the history

  5. chore(type-utils): Using unknown instead of any in tests

    @marekdedic
    marekdedic committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    b5b91cb View commit details
    Browse the repository at this point in the history

  6. test(type-utils): grammar fix in test specifications

    @marekdedic
    marekdedic committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    e41d8be View commit details
    Browse the repository at this point in the history

  7. chore: Reset yarn.lock

    @marekdedic
    marekdedic committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    852ca69 View commit details
    Browse the repository at this point in the history

  8. chore: renamed readonlyness allowlist to just allow

    @marekdedic
    marekdedic committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    5407105 View commit details
    Browse the repository at this point in the history

  9. fix(type-utils): fixed services.program now being optional and not ch… 

    …ecked in tests
    @marekdedic
    marekdedic committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    b9f785c View commit details
    Browse the repository at this point in the history

  10. test(type-utils): negative tests for isTypeReadonly

    @marekdedic
    marekdedic committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    8626d16 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2023

  1. fix(eslint-plugin): bracket style array notation 

    Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
    @marekdedic @JoshuaKGoldberg
    marekdedic and JoshuaKGoldberg committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    235acd3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'v6' into prefer-readonly-parameter-types-whitelist

    @marekdedic
    marekdedic committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    a1f38dd View commit details
    Browse the repository at this point in the history

  3. Merge branch 'prefer-readonly-parameter-types-whitelist' of github.co… 

    …m:marekdedic/typescript-eslint into prefer-readonly-parameter-types-whitelist
    @marekdedic
    marekdedic committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    93fbcd8 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2023

  1. Merge branch 'v6' into prefer-readonly-parameter-types-whitelist

    @marekdedic
    marekdedic committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    3ad0e9e View commit details
    Browse the repository at this point in the history

  2. fix(type-utils): Fixed array style

    @marekdedic
    marekdedic committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    0bd7601 View commit details
    Browse the repository at this point in the history

  3. fix(type-utils): Not fetching symbol repeatedly

    @marekdedic
    marekdedic committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    0136e5b View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2023

  1. fix(type-utils): Remove ManySpecifiers format from TypeOrValueSpecifi… 

    …er schema
    @marekdedic
    marekdedic committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    386fd03 View commit details
    Browse the repository at this point in the history

  2. docs(eslint-plugin): [prefer-readonly-parameter-types] described file… 

    … specifier path as being relative
    @marekdedic
    marekdedic committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    ed1e07a View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2023

  1. Merge branch 'v6' into prefer-readonly-parameter-types-whitelist

    @bradzacher
    bradzacher committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    3a89ec5 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2023

  1. path and package

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    346fdbc View commit details
    Browse the repository at this point in the history

  2. Update docs too

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    609351e View commit details
    Browse the repository at this point in the history

  3. Update docs too (again)

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    a535fb6 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'v6'

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    8e3f910 View commit details
    Browse the repository at this point in the history

  5. Added test name helpers, and fixed test data

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    95bbaa5 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. test(type-utils): fixed package schema tests

    @marekdedic
    marekdedic committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    5eae317 View commit details
    Browse the repository at this point in the history

  2. test(eslint-plugin): fixed type whitelist schema in prefer-readonly-p… 

    …arameter-types tests
    @marekdedic
    marekdedic committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    751e2de View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2023

  1. Applied lowercasing to typeDeclaredInFile

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    3d465cc View commit details
    Browse the repository at this point in the history