#11857 test on py 3.12rc

.github/workflows/test.yaml

@@ -69,7 +69,7 @@ jobs:
         # The Python version on which the job is executed.
         # We need at least one value here, so we go with latest Python version
         # that we support..
-        python-version: ['3.10']
+        python-version: ['3.11']
         # Just use the default OS.
         runs-on: ['']
         # Human readable short description for this job.
@@ -124,8 +124,11 @@ jobs:
           # Just Python 3.9 with default settings.
           - python-version: '3.9'
 
-          # Just Python 3.11 with default settings.
-          - python-version: '3.11'
+          # Just Python 3.10 with default settings.
+          - python-version: '3.10'
+
+          # Just Python 3.12 with default settings.
+          - python-version: '3.12'
 
           # Newest macOS and newest Python supported versions.
           - python-version: '3.11'
@@ -184,6 +187,7 @@ jobs:
       uses: actions/setup-python@v4
       with:
         python-version: ${{ matrix.python-version }}
+        allow-prereleases: true
 
     - name: Get pip cache dir
       id: pip-cache

src/twisted/internet/defer.py

@@ -9,6 +9,7 @@
 """
 from __future__ import annotations
 
+import inspect
 import traceback
 import warnings
 from abc import ABC, abstractmethod
@@ -1341,8 +1342,9 @@ def main(reactor):
 
         @raise ValueError: If C{coro} is not a coroutine or generator.
         """
-        # asyncio.iscoroutine identifies generators as coroutines, too.
-        if iscoroutine(coro):
+        # asyncio.iscoroutine <3.12 identifies generators as coroutines, too.
+        # for >=3.12 we need to check isgenerator also
+        if iscoroutine(coro) or inspect.isgenerator(coro):
             return _cancellableInlineCallbacks(coro)
         raise NotACoroutineError(f"{coro!r} is not a coroutine")
 

src/twisted/newsfragments/11857.feature

@@ -0,0 +1 @@
+The CI suite was updated to execute the tests using a Python 3.12 pre-release

src/twisted/newsfragments/11908.bugfix

@@ -0,0 +1,2 @@
+utcfromtimestamp has been deprecated since Python 3.12,
+use fromtimestamp(x, timezone.utc).replace(tzinfo=None) instead.

src/twisted/persisted/aot.py

@@ -231,13 +231,17 @@ def indentify(s):
     out = []
     stack = []
     l = ["", s]
+
+    def readline():
+        return l.pop().replace("\0", "")
+
     for (
         tokenType,
         tokenString,
         (startRow, startColumn),
         (endRow, endColumn),
         logicalLine,
-    ) in tokenize(l.pop):
+    ) in tokenize(readline):
         if tokenString in ["[", "(", "{"]:
             stack.append(tokenString)
         elif tokenString in ["]", ")", "}"]:

src/twisted/python/_tzhelper.py

@@ -6,7 +6,12 @@
 Time zone utilities.
 """
 
-from datetime import datetime as DateTime, timedelta as TimeDelta, tzinfo as TZInfo
+from datetime import (
+    datetime as DateTime,
+    timedelta as TimeDelta,
+    timezone,
+    tzinfo as TZInfo,
+)
 from typing import Optional
 
 __all__ = [
@@ -68,9 +73,9 @@ def fromLocalTimeStamp(cls, timeStamp: float) -> "FixedOffsetTimeZone":
         Create a time zone with a fixed offset corresponding to a time stamp in
         the system's locally configured time zone.
         """
-        offset = DateTime.fromtimestamp(timeStamp) - DateTime.utcfromtimestamp(
-            timeStamp
-        )
+        offset = DateTime.fromtimestamp(timeStamp) - DateTime.fromtimestamp(
+            timeStamp, timezone.utc
+        ).replace(tzinfo=None)
         return cls(offset)
 
     def utcoffset(self, dt: Optional[DateTime]) -> TimeDelta:

src/twisted/python/log.py

@@ -11,7 +11,7 @@
 import time
 import warnings
 from abc import ABC, abstractmethod
-from datetime import datetime
+from datetime import datetime, timezone
 from typing import Any, BinaryIO, Dict, Optional, cast
 
 from zope.interface import Interface
@@ -490,7 +490,9 @@ def getTimezoneOffset(self, when):
         @return: The number of seconds offset from UTC.  West is positive,
         east is negative.
         """
-        offset = datetime.utcfromtimestamp(when) - datetime.fromtimestamp(when)
+        offset = datetime.fromtimestamp(when, timezone.utc).replace(
+            tzinfo=None
+        ) - datetime.fromtimestamp(when)
         return offset.days * (60 * 60 * 24) + offset.seconds
 
     def formatTime(self, when):
@@ -512,7 +514,9 @@ def formatTime(self, when):
             return datetime.fromtimestamp(when).strftime(self.timeFormat)
 
         tzOffset = -self.getTimezoneOffset(when)
-        when = datetime.utcfromtimestamp(when + tzOffset)
+        when = datetime.fromtimestamp(when + tzOffset, timezone.utc).replace(
+            tzinfo=None
+        )
         tzHour = abs(int(tzOffset / 60 / 60))
         tzMin = abs(int(tzOffset / 60 % 60))
         if tzOffset < 0:

src/twisted/test/test_task.py

@@ -467,6 +467,13 @@ def test_withCountFloatingPointBoundary(self):
         for x in range(count):
             clock.advance(interval)
 
+        # work around https://github.com/python/cpython/issues/100425 on py312
+        def sum(items):
+            total = 0.0
+            for item in items:
+                total += item
+            return total
+
         # There is still an epsilon of inaccuracy here; 0.1 is not quite
         # exactly 1/10 in binary, so we need to push our clock over the
         # threshold.

src/twisted/trial/_synctest.py

@@ -1328,7 +1328,8 @@ def mktemp(self):
         )
         if not os.path.exists(base):
             os.makedirs(base)
-        dirname = tempfile.mkdtemp("", "", base)
+        # workaround https://github.com/python/cpython/issues/51574
+        dirname = os.path.relpath(tempfile.mkdtemp("", "", base))
         return os.path.join(dirname, "temp")
 
     def _getSuppress(self):