-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#11857 test on py 3.12rc #11910
#11857 test on py 3.12rc #11910
Conversation
relevant cpython issues: python/cpython#51574 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. thanks!
Changes looks good. I hope someone can take a look and review the defered coroutine part.
Or maybe an updated comment can help.
# asyncio.iscoroutine <3.12 identifies generators as coroutines, too. | ||
# for >=3.12 we need to check isgenerator also | ||
# see https://github.com/python/cpython/issues/102748 | ||
if iscoroutine(coro) or inspect.isgenerator(coro): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have experince with coroutine.
I don't understand this comment. Sorry
I see that the current tests are with 3.12.0-rc.1 ... but the setup is to test with any latest 3.12 . I think that's fine. And I think that the scope of this PR is not only to get tests on py3.12 , but also a general update of twisted codebase for 3.12 ... for example the deprecationwarning fix |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not happy with vendoring...but if the plan is to remove aot, it should be fine.
Co-authored-by: Adi Roiban <adiroiban@gmail.com>
Co-authored-by: Adi Roiban <adiroiban@gmail.com>
Co-authored-by: Adi Roiban <adiroiban@gmail.com>
Co-authored-by: Adi Roiban <adiroiban@gmail.com>
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I am happy with the changes.
Not sure about the corouting part, as I don't have experince with that.
but as long as the tests are green, it should be fine.
Many thanks!
Scope and purpose
Fixes #11857 and #11888