#11857 test on py 3.12rc #11910
Merged
#11857 test on py 3.12rc #11910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
commented
Aug 16, 2023
graingert
commented
Aug 16, 2023
|
relevant cpython issues: python/cpython#51574 |
adiroiban
reviewed
Aug 16, 2023
| # asyncio.iscoroutine <3.12 identifies generators as coroutines, too. | ||
| # for >=3.12 we need to check isgenerator also | ||
| # see https://github.com/python/cpython/issues/102748 | ||
| if iscoroutine(coro) or inspect.isgenerator(coro): |
There was a problem hiding this comment.
I don't have experince with coroutine.
I don't understand this comment. Sorry
|
I see that the current tests are with 3.12.0-rc.1 ... but the setup is to test with any latest 3.12 . I think that's fine. And I think that the scope of this PR is not only to get tests on py3.12 , but also a general update of twisted codebase for 3.12 ... for example the deprecationwarning fix |
graingert
commented
Aug 16, 2023
for more information, see https://pre-commit.ci
adiroiban
reviewed
Aug 16, 2023
Co-authored-by: Adi Roiban <adiroiban@gmail.com>
Co-authored-by: Adi Roiban <adiroiban@gmail.com>
Co-authored-by: Adi Roiban <adiroiban@gmail.com>
Co-authored-by: Adi Roiban <adiroiban@gmail.com>
for more information, see https://pre-commit.ci
adiroiban
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope and purpose
Fixes #11857 and #11888