Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rt: do not trace tasks while locking
OwnedTasks
#6036rt: do not trace tasks while locking
OwnedTasks
#6036Changes from 4 commits
a8577e8
6331ddb
db49d55
2849fb3
fe4b3a8
1a904c8
4264f61
f770673
05a3422
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, so, I've figured out how I think we should handle this refcount business:
transition_to_notified_for_tracing
with a method onTask
that returns aNotified
. ThisNotified
will own the refcount that we created inside oftransition_to_notified_for_tracing
.poll
directly, you instead useOwnedTasks::assert_owner
to convert theNotified
into aLocalNotified
.LocalNotified::run
.This way, we only increment the refcount once (so there's no call to
Task::clone
), and all refcounts we create are owned byNotified
object, so their destructor will clear it if it gets dropped before it is polled, e.g. due to a panic.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!