Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rt: do not trace tasks while locking OwnedTasks #6036

Merged
merged 9 commits into from Oct 6, 2023
Merged

rt: do not trace tasks while locking OwnedTasks #6036

merged 9 commits into from Oct 6, 2023

Commits on Sep 27, 2023

  1. rt: do not trace tasks while locking OwnedTasks 

    If a polled tasks completes while `OwnedTasks` is locked, it will
not be able to remove itself from `OwnedTasks`, resulting in a
deadlock.

Fixes tokio-rs#6035.
    @jswrenn
    jswrenn committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    a8577e8 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. Merge branch 'master' into taskdump-deadlock-fix

    @jswrenn
    jswrenn committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    6331ddb View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. remove needless re-scheduling and add regression tests

    @jswrenn
    jswrenn committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    db49d55 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. rt: don't persist raw tasks

    @jswrenn
    jswrenn committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    2849fb3 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. encapsulate ref-count management for tracing 

    See tokio-rs#6036 (comment)
    @jswrenn
    jswrenn committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    fe4b3a8 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. don't increment refcount in transition_to_notified_for_tracing 

    `notify_for_tracing` already increments refcount with its `clone`,
and `LocalNotified::run` forgets (not drops) the underlying task.
    @jswrenn
    jswrenn committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    1a904c8 View commit details
    Browse the repository at this point in the history

  2. don't clone in notify_for_tracing

    @jswrenn
    jswrenn committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    4264f61 View commit details
    Browse the repository at this point in the history

  3. don't clone in trace_owned

    @jswrenn
    jswrenn committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    f770673 View commit details
    Browse the repository at this point in the history

  4. remove dead Clone impl for Task

    @jswrenn
    jswrenn committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    05a3422 View commit details
    Browse the repository at this point in the history