Rollback MSRV bump #208
Merged
Rollback MSRV bump #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following updates are performed: * update actions/checkout to v4 * replace unmaintained actions-rs/toolchain by dtolnay/rust-toolchain * replace unmaintained actions-rs/cargo by direct invocation of cargo
Signed-off-by: Tom Kaitchuck <Tom.Kaitchuck@gmail.com>
* Bump rust-version to 1.72.0 * Bump rust version in MSRC CI check
…197) Increase the MSRV presubmit checks to include multiple architectures Signed-off-by: Tom Kaitchuck <Tom.Kaitchuck@gmail.com>
Merge master into release 0.8 branch
Signed-off-by: Tom Kaitchuck <Tom.Kaitchuck@gmail.com>
Signed-off-by: Tom Kaitchuck <Tom.Kaitchuck@gmail.com>
samguns
approved these changes
Feb 17, 2024
tnull
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
Can confirm this branch works for me with rustc 1.63.
One nit, getting a warning from an unused import, might want to cfg-gate it accordingly:
> cargo +1.63 build
warning: file found to be present in multiple build targets: /Users/USER/workspace/aHash/tests/bench.rs
warning: unused import: `zerocopy::transmute`
--> src/operations.rs:2:5
|
2 | use zerocopy::transmute;
| ^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
warning: `ahash` (lib) generated 1 warning
It would also be great to add a MSRV check to CI to ensure it will be monitored continuously.
Signed-off-by: Tom Kaitchuck <Tom.Kaitchuck@gmail.com>
tkaitchuck
added a commit
that referenced
this pull request
Feb 20, 2024
2 tasks
This was referenced Feb 20, 2024
This was referenced Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts part of the broadening of the scope in #183 to avoid the errors caused by #200 without having to increase the MSRV. This reverts #195
and fixes #207