Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove upper-bound on ahash dependency version #454

Closed
AlexandreCassagne opened this issue Feb 27, 2024 · 4 comments
Closed

Remove upper-bound on ahash dependency version #454

AlexandreCassagne opened this issue Feb 27, 2024 · 4 comments
Labels
C-core Component: core functionality such as traits, etc. E-simple Effort: simple. T-ergonomics Type: ergonomics.

Comments

@AlexandreCassagne
Copy link

AlexandreCassagne commented Feb 27, 2024 •
edited

Commit f7e979a (fix ahash MSRV nonsense) locks down the version of ahash to <= 0.8.7

This breaks our build alongside actix-web v4.5.1 which calls for ahash 0.8.9.

I can see there are some more recent commits in ahash (main) but I do not understand the underlying issue well enough to determine if the bug was fixed there.

Can you link this issue to a blocking issue on ahash so we can un-pin the dependency again on this repo?

cc @tobz
@AlexandreCassagne
Copy link
Author

It looks like this MSRV bump was rolled back in this PR
tkaitchuck/aHash#208

@tobz
Copy link
Member

tobz commented Feb 28, 2024

Oh neat. If the MSRV bump has been reverted as of ahash 0.8.8, then we can remove the range constraint and instead pin to 0.8.8.

@tobz tobz added C-core Component: core functionality such as traits, etc. E-simple Effort: simple. T-ergonomics Type: ergonomics. S-awaiting-release Status: awaiting a release to be considered fixed/implemented. labels Feb 28, 2024
@tobz
Copy link
Member

tobz commented Mar 16, 2024

Released in metrics@v0.22.2.

@tobz tobz closed this as completed Mar 16, 2024
@tobz tobz removed the S-awaiting-release Status: awaiting a release to be considered fixed/implemented. label Mar 16, 2024
@AlexandreCassagne
Copy link
Author

Thanks @tobz.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-core Component: core functionality such as traits, etc. E-simple Effort: simple. T-ergonomics Type: ergonomics.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tobz @AlexandreCassagne