✅ Refactor tests for duplicate operation ID generation for compatibility with other tools running the FastAPI test suite #10876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…third-party runtime wrappers like ddtrace-run
18 tasks
tiangolo
changed the title
|
Cool, thanks @emmettbutler! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a failure of
test_warn_duplicate_operation_idthat occurs when it runs under Datadog'sddtrace-runruntime wrapper. This failure was induced by the changes in DataDog/dd-trace-py#7957, which add a deprecation warning for an internal Datadog feature.This change makes sense to merge because the possibility of wrapper libraries emitting warnings is not limited to dd-trace-py.