Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate the span= arguments on ExecutionContext methods #7957

Merged
merged 10 commits into from Jan 3, 2024

Conversation

emmettbutler
Copy link
Collaborator

@emmettbutler emmettbutler commented Dec 19, 2023

This pull request deprecates the span arguments on ExecutionContext methods to indicate that they are only for backward compatibility and not meant to be used by newly written code. This has been the plan since the beginning of the core API in #6202 (comment).

Deprecations are usually used for non-internal functionality, but I think a deprecation is appropriate in this internal case as we encourage broader usage of the core API.

This changed caused a failure in the fastapi framework test suite, which I think is the result of that test being too strict in its expectations. This pull request skips that test and adds a fallback that avoids the deprecation warning when fastapi is loaded. I've also opened tiangolo/fastapi#10876 making the fastapi framework test more permissive.

Checklist

  • Change(s) are motivated and described in the PR description.
  • Testing strategy is described if automated tests are not included in the PR.
  • Risk is outlined (performance impact, potential for breakage, maintainability, etc).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Library release note guidelines are followed. If no release note is required, add label changelog/no-changelog.
  • Documentation is included (in-code, generated user docs, public corp docs).
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Title is accurate.
  • No unnecessary changes are introduced.
  • Description motivates each change.
  • Avoids breaking API changes unless absolutely necessary.
  • Testing strategy adequately addresses listed risk(s).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Release note makes sense to a user of the library.
  • Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment.
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy
  • If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

@emmettbutler emmettbutler requested a review from a team as a code owner December 19, 2023 19:43
@emmettbutler emmettbutler added the changelog/no-changelog A changelog entry is not required for this PR. label Dec 19, 2023
@majorgreys majorgreys enabled auto-merge (squash) December 20, 2023 18:56
@pr-commenter
Copy link

pr-commenter bot commented Dec 20, 2023

Benchmarks

Benchmark execution time: 2024-01-02 20:08:38

Comparing candidate commit e29200b in PR branch emmett.butler/deprecate-core-span with baseline commit 14d3cbc in branch main.

Found 3 performance improvements and 8 performance regressions! Performance is the same for 184 metrics, 9 unstable metrics.

scenario:coreapiscenario-get_item_exists

  • 🟥 execution_time [+98.426ns; +103.909ns] or [+18.385%; +19.409%]

scenario:coreapiscenario-get_item_missing

  • 🟥 execution_time [+92.209ns; +102.764ns] or [+15.075%; +16.801%]

scenario:flasksimple-appsec-get

  • 🟩 max_rss_usage [-992.084KB; -832.275KB] or [-2.751%; -2.308%]

scenario:flasksimple-appsec-post

  • 🟩 max_rss_usage [-1.190MB; -0.972MB] or [-3.294%; -2.692%]

scenario:flasksimple-baseline

  • 🟥 max_rss_usage [+730.612KB; +926.220KB] or [+2.063%; +2.615%]

scenario:otelspan-add-metrics

  • 🟥 execution_time [+6.591ms; +11.302ms] or [+2.453%; +4.207%]

scenario:otelspan-add-tags

  • 🟥 execution_time [+7.656ms; +11.599ms] or [+3.091%; +4.683%]

scenario:otelspan-start

  • 🟥 execution_time [+7.970ms; +10.751ms] or [+17.714%; +23.893%]
  • 🟩 max_rss_usage [-5.402MB; -5.213MB] or [-10.625%; -10.253%]

scenario:otelspan-start-finish

  • 🟥 execution_time [+9.187ms; +10.718ms] or [+12.493%; +14.575%]

scenario:otelspan-start-finish-telemetry

  • 🟥 execution_time [+9.347ms; +10.643ms] or [+12.744%; +14.512%]

@majorgreys majorgreys merged commit 14c0a97 into main Jan 3, 2024
140 checks passed
@majorgreys majorgreys deleted the emmett.butler/deprecate-core-span branch January 3, 2024 15:22
ZStriker19 pushed a commit to haozhun/dd-trace-py that referenced this pull request Jan 8, 2024
…aDog#7957)

This pull request deprecates the `span` arguments on `ExecutionContext`
methods to indicate that they are only for backward compatibility and
not meant to be used by newly written code. This has been the plan since
the beginning of the core API in
DataDog#6202 (comment).

Deprecations are usually used for non-internal functionality, but I
think a deprecation is appropriate in this internal case as we encourage
broader usage of the core API.

## Checklist

- [x] Change(s) are motivated and described in the PR description.
- [x] Testing strategy is described if automated tests are not included
in the PR.
- [x] Risk is outlined (performance impact, potential for breakage,
maintainability, etc).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed. If no release note is required, add label
`changelog/no-changelog`.
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/)).
- [x] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist

- [x] Title is accurate.
- [x] No unnecessary changes are introduced.
- [x] Description motivates each change.
- [x] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes unless absolutely necessary.
- [x] Testing strategy adequately addresses listed risk(s).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] Release note makes sense to a user of the library.
- [x] Reviewer has explicitly acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment.
- [x] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
- [x] If this PR touches code that signs or publishes builds or
packages, or handles credentials of any kind, I've requested a review
from `@DataDog/security-design-and-guidance`.
- [x] This PR doesn't touch any of that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants